Pretty permalink on search

[markjaquith]

Ryan:

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems.

[5454] was the commit for #3930

If at all possible, I'd like to work with the new code.

[MtDewVirus]

Tested with 7236.

Whenever performing searches, the search results do have URLs in the form of /?s=test.

[DD32]

What would be a suggested fix for this ticket? /search/search-term/page/2 ? /?s=search-term&paged=2 ?

[Denis-de-Bernardy]

+1 for this: /?s=search-term&paged=2

[hakre]

/search/search-term/page/2 with a configureable option in backend for wording of "search" would be pretty nice to fillup serps.

anyway isn't this pretty uninteresting anyway as long as it doesn't lead to a 404?

[janeforshort]

No patch, punting.

[wonderboymusic]

Is this still relevant?

[SergeyBiryukov]

Paged search links still look as described: http://trunk.wordpress/page/2/?s=test.

Before [5454], they used to be http://trunk.wordpress/?s=test&paged=2.

[wonderboymusic]

Makes search links with pretty permalinks on used paged in the query string

[wonderboymusic]

Refreshed patch against trunk - this ticket is like 19,000 tickets old, but the patch works

[wonderboymusic]

#21748 was marked as a duplicate.

[faishal]

New patch

[MikeHansenMe]

Both 4463.diff and 4463_1.diff apply and work as intended. In 4463_1.diff there is a couple addition lines for is_single ! is_home and ! is_front_page. I am not sure if that is necessary as 4463.diff seems to work without it.

[nacin]

Longstanding bug.

[wonderboymusic]

these are all marked 3.7-early

[Mte90]

Just adding a more context focused title to avoid reading all the history in this 16 years ticket.

I don't know if it is something that we want, I mean now it is a standard that on wordpress the only parameter not pretty is s for the search.

The topic was opened because at the time there were some changes on adding as pretty the paged value.

As today, all the search engine doesn't have pretty permalinks for the search string value like Google.