WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 5 months ago

#4463 new defect (bug)

Strange paging links

Reported by: markjaquith Owned by: ryan
Milestone: Future Release Priority: normal
Severity: normal Version: 2.3
Component: Permalinks Keywords: 3.7-early has-patch needs-unit-tests
Focuses: Cc:

Description

Ryan:

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems.

[5454] was the commit for #3930

If at all possible, I'd like to work with the new code.

Attachments (2)

4463.diff (956 bytes) - added by wonderboymusic 15 months ago.
4463_1.diff (1.1 KB) - added by faishal 12 months ago.
New patch

Download all attachments as: .zip

Change History (20)

comment:1 Nazgul7 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.3 (trunk) to 2.4 (future)

comment:2 MtDewVirus6 years ago

Tested with 7236.

Whenever performing searches, the search results do have URLs in the form of /?s=test.

comment:3 DD325 years ago

  • Component changed from General to Template
  • Priority changed from high to normal

What would be a suggested fix for this ticket? /search/search-term/page/2 ? /?s=search-term&paged=2 ?

comment:4 Denis-de-Bernardy5 years ago

+1 for this: /?s=search-term&paged=2

comment:5 Denis-de-Bernardy5 years ago

  • Component changed from Template to Permalinks
  • Owner changed from anonymous to ryan

comment:6 hakre5 years ago

/search/search-term/page/2 with a configureable option in backend for wording of "search" would be pretty nice to fillup serps.

anyway isn't this pretty uninteresting anyway as long as it doesn't lead to a 404?

comment:7 janeforshort4 years ago

  • Milestone changed from 2.9 to Future Release

No patch, punting.

comment:8 wonderboymusic19 months ago

  • Keywords reporter-feedback added; needs-patch removed

Is this still relevant?

comment:9 SergeyBiryukov19 months ago

  • Keywords needs-patch added; reporter-feedback removed

Paged search links still look as described: http://trunk.wordpress/page/2/?s=test.

Before [5454], they used to be http://trunk.wordpress/?s=test&paged=2.

comment:10 wonderboymusic18 months ago

  • Keywords has-patch added; needs-patch removed

Makes search links with pretty permalinks on used paged in the query string

wonderboymusic15 months ago

comment:11 wonderboymusic15 months ago

  • Milestone changed from Future Release to 3.6

Refreshed patch against trunk - this ticket is like 19,000 tickets old, but the patch works

comment:12 wonderboymusic15 months ago

#21748 was marked as a duplicate.

faishal12 months ago

New patch

comment:13 faishal12 months ago

  • Cc saiyedfaishal@… added

comment:14 MikeHansenMe11 months ago

  • Cc mdhansen@… added

Both 4463.diff and 4463_1.diff apply and work as intended. In 4463_1.diff there is a couple addition lines for is_single ! is_home and ! is_front_page. I am not sure if that is necessary as 4463.diff seems to work without it.

comment:15 nacin9 months ago

  • Keywords 3.7-early added
  • Milestone changed from 3.6 to Future Release

Longstanding bug.

comment:16 wonderboymusic9 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:17 wonderboymusic7 months ago

  • Keywords needs-unit-tests added
  • Milestone changed from 3.7 to 3.8

comment:18 dd325 months ago

  • Milestone changed from 3.8 to Future Release
Note: See TracTickets for help on using tickets.