WordPress.org

Make WordPress Core

Opened 10 years ago

Last modified 2 years ago

#4463 reviewing defect (bug)

Strange paging links

Reported by: markjaquith Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.3
Component: Permalinks Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

Ryan:

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems.

[5454] was the commit for #3930

If at all possible, I'd like to work with the new code.

Attachments (2)

4463.diff (956 bytes) - added by wonderboymusic 5 years ago.
4463_1.diff (1.1 KB) - added by faishal 5 years ago.
New patch

Download all attachments as: .zip

Change History (23)

#1 @Nazgul
10 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.3 (trunk) to 2.4 (future)

#2 @MtDewVirus
10 years ago

Tested with 7236.

Whenever performing searches, the search results do have URLs in the form of /?s=test.

#3 @DD32
9 years ago

  • Component changed from General to Template
  • Priority changed from high to normal

What would be a suggested fix for this ticket? /search/search-term/page/2 ? /?s=search-term&paged=2 ?

#4 @Denis-de-Bernardy
9 years ago

+1 for this: /?s=search-term&paged=2

#5 @Denis-de-Bernardy
9 years ago

  • Component changed from Template to Permalinks
  • Owner changed from anonymous to ryan

#6 @hakre
8 years ago

/search/search-term/page/2 with a configureable option in backend for wording of "search" would be pretty nice to fillup serps.

anyway isn't this pretty uninteresting anyway as long as it doesn't lead to a 404?

#7 @janeforshort
8 years ago

  • Milestone changed from 2.9 to Future Release

No patch, punting.

#8 @wonderboymusic
5 years ago

  • Keywords reporter-feedback added; needs-patch removed

Is this still relevant?

#9 @SergeyBiryukov
5 years ago

  • Keywords needs-patch added; reporter-feedback removed

Paged search links still look as described: http://trunk.wordpress/page/2/?s=test.

Before [5454], they used to be http://trunk.wordpress/?s=test&paged=2.

#10 @wonderboymusic
5 years ago

  • Keywords has-patch added; needs-patch removed

Makes search links with pretty permalinks on used paged in the query string

@wonderboymusic
5 years ago

#11 @wonderboymusic
5 years ago

  • Milestone changed from Future Release to 3.6

Refreshed patch against trunk - this ticket is like 19,000 tickets old, but the patch works

#12 @wonderboymusic
5 years ago

#21748 was marked as a duplicate.

@faishal
5 years ago

New patch

#13 @faishal
5 years ago

  • Cc saiyedfaishal@… added

#14 @MikeHansenMe
4 years ago

  • Cc mdhansen@… added

Both 4463.diff and 4463_1.diff apply and work as intended. In 4463_1.diff there is a couple addition lines for is_single ! is_home and ! is_front_page. I am not sure if that is necessary as 4463.diff seems to work without it.

#15 @nacin
4 years ago

  • Keywords 3.7-early added
  • Milestone changed from 3.6 to Future Release

Longstanding bug.

#16 @wonderboymusic
4 years ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

#17 @wonderboymusic
4 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from 3.7 to 3.8

#18 @dd32
4 years ago

  • Milestone changed from 3.8 to Future Release

#19 @ryan
3 years ago

  • Owner ryan deleted
  • Status changed from new to assigned

#20 @chriscct7
2 years ago

  • Keywords 3.7-early removed
  • Milestone changed from Future Release to 4.4
  • Owner set to chriscct7
  • Status changed from assigned to reviewing

#21 @chriscct7
2 years ago

  • Milestone changed from 4.4 to Future Release
  • Owner chriscct7 deleted
Note: See TracTickets for help on using tickets.