WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#44633 closed defect (bug) (fixed)

Commented out code in class-wp-customize-nav-menus.php

Reported by: harsh175 Owned by: DrewAPicture
Priority: normal Milestone: 5.1
Component: Customize Version: 4.3
Severity: minor Keywords: has-patch commit
Cc: Focuses: docs

Description

I found commented out code in /wp-includes/class-wp-customize-nav-menus.php

These actions are no longer available anywhere.

As consider coding standards we should remove the unused actions from the file.

Attachments (2)

44633.patch​ (485 bytes ) - added by harsh175 8 years ago.
44633.2.patch​ (905 bytes ) - added by dlh 8 years ago.

Download all attachments as: .zip

Change History (7)

@harsh175
8 years ago

#1 @SergeyBiryukov
8 years ago

  • Component General → Customize

@dlh
8 years ago

#2 @dlh
8 years ago

  • Version trunk → 4.3

44633.2.patch​ amends the original patch slightly to keep the "todo" itself, which, I think, is still relevant.

#3 @westonruter
8 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 5.0

#4 @SergeyBiryukov
8 years ago

  • Milestone 5.0 → 5.1

#5 @DrewAPicture
8 years ago

  • Owner set to DrewAPicture
  • Resolution → fixed
  • Status new → closed

In 44328:

Customizer: Remove a line of commented-out code in WP_Customize_Nav_Menus::customize_register().

Retains a more explicit future-compat version of the todo notation that used to accompany the commented-out code.

Props harsh175, dlh.
Fixes #44633.

Note: See TracTickets for help on using tickets.