WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#44635 closed defect (bug) (invalid)

Getting an error after installing Gutenberg after Classic Editor.

Reported by: chetan200891 Owned by:
Milestone: Priority: highest omg bbq
Severity: major Version: 5.1
Component: Editor Keywords: needs-patch
Focuses: administration Cc:

Description

| WordPress 4.9.8 RC 1 release works fine on fresh install.

But when you install Classic editor first and activate. After that installing Gutenberg and activate, getting error Sorry, you are not allowed to access this page.

Steps to reproduce the issue.

1) Click Install Classic Editor

2) Activate Classic Editor

3) Click Install Gutenberg

4) Activate Gutenberg

5) Error message “Sorry, you are not allowed to access this page.”

Also I have recorded video about this issue. | Click here to view.

Change History (11)

This ticket was mentioned in Slack in #core by chetan200891. View the logs.


10 months ago

#2 @audrasjb
10 months ago

Hey,

In wp-admin/plugins.php, L.69:
When I replace:

                                if ( 'gutenberg/gutenberg.php' === $plugin ) {
                                        wp_redirect( self_admin_url( "admin.php?page=gutenberg" ) );
                                } else {
                                        wp_redirect( self_admin_url() );
                                }

With:

                                wp_redirect( self_admin_url() );

It works fine on my side.

Cheers,

Jb

Last edited 10 months ago by audrasjb (previous) (diff)

#3 follow-up: @audrasjb
10 months ago

I guess it happens because Classic Editor deactivate the admin.php?page=gutenberg which redirects to post-new.php?gutenberg-demo. In any case I think Gutenberg activation should always redirect to the dashboardwhen launched from the dashboard, but not when activated from the plugins area. Then, I'm afraid my first attempt is a first step but not ready to go "as it" :)

This ticket was mentioned in Slack in #core-editor by pbiron. View the logs.


10 months ago

#5 @chetan200891
10 months ago

  • Focuses administration added

#6 @netweb
10 months ago

  • Milestone changed from Awaiting Review to 4.9.8
  • Priority changed from normal to highest omg bbq

#7 in reply to: ↑ 3 @earnjam
10 months ago

Replying to audrasjb:

I think Gutenberg activation should always redirect to the dashboardwhen launched from the dashboard, but not when activated from the plugins area.

Right now, it only redirects when activated from the dashboard/Try Gutenberg callout. If activated from plugins, it just redirects back to /wp-admin/plugins.php. I think this is ok functionality to send a user straight to the demo if they are trying it from the callout in the dashboard.

The solution @audrasjb suggested above works to prevent users from hitting the error message, however I think it's still confusing. If a user installs/activates Classic Editor, they will still see the Try Gutenberg banner. Then if they were to click to Install/Activate Gutenberg while on the dashboard, the Try Gutenberg banner just disappears.

It would be better to either hide that banner anytime the Classic Editor plugin is active, or provide some messaging that they'll need to deactivate it before they can actually Try Gutenberg.

The Classic Editor plugin only unhooks the Try Gutenberg panel when Gutenberg is active. It might be easiest to just change that, so if Classic Editor plugin is active, then the Try Gutenberg panel doesn't show (regardless of whether Gutenberg is active). That wouldn't involve a change to today's RC. Thoughts @azaozz?

Last edited 10 months ago by earnjam (previous) (diff)

#8 follow-up: @pento
10 months ago

  • Milestone 4.9.8 deleted
  • Resolution set to invalid
  • Status changed from new to closed

That's a bug in the Classic Editor plugin, it's supposed to be removing the Try Gutenberg callout all the time, but it doesn't remove it if the Gutenberg plugin isn't installed.

I'm closing this issue so it can be fixed in the plugin.

https://github.com/WordPress/classic-editor/issues/1

#9 in reply to: ↑ 8 @azaozz
10 months ago

Replying to pento:

Heh, there is already a gh mirror of Classic Editor (not sure if up to date though). Having another one is... perhaps too much? :)

Anyway, looking at the issues there, two are already fixed in the plugin. Will fix the third: removing the beta software warning in a min.

Not sure about the forth though. Do we really want Classic Editor to completely eradicate all traces of Gutenberg? Won't that leave some WordPress users "in the dark"? Seems wrong perhaps?

Last edited 10 months ago by azaozz (previous) (diff)

#10 follow-up: @pento
10 months ago

Yeah, I saw your mirror, but it was out of date, so I made a new one on the WordPress GitHub org. Let's use the WordPress one, so we have a more official place to manage it.

Good point on eradicating all traces, I'll post on the GitHub issue about it.

#11 in reply to: ↑ 10 @azaozz
10 months ago

Replying to pento:

Let's use the WordPress one, so we have a more official place to manage it.

That's good but I can't push anything there.. :(

Updated the plugin to 0.4 (had some stuff ready from last week). All known problems should be fixed now.

Last edited 10 months ago by azaozz (previous) (diff)
Note: See TracTickets for help on using tickets.