WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44654, comment 1


Ignore:
Timestamp:
07/27/2018 05:40:35 AM (6 years ago)
Author:
mnelson4
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #44654, comment 1

    initial v1  
    11Oh, I actually just learned PHP is ok with using forward slashes, even when ran from Windows (see https://stackoverflow.com/questions/3554817/using-directory-separator-in-file-exists-on-windows#3554966). My problems were just in unit tests that incorrectly expected the operating system's directory separator to be used.
    22I ranted on this topic quite a bit on my blog: https://cmljnelson.wordpress.com/2018/07/26/which-way-do-your-slashes-face/
    3 But basically, while I'd prefer to use DIRECTORY_SEPARATOR, I think the die has been cast, WordPress uses forward slashes in PHP code, even for filepaths. So I think it's ok to just close this.
     3But basically, while I'd prefer to use DIRECTORY_SEPARATOR, I think the dye has been cast, WordPress uses forward slashes in PHP code, even for filepaths. So I think it's ok to just close this.