WordPress.org

Make WordPress Core

Opened 12 months ago

Last modified 4 months ago

#44662 new enhancement

Text length of the Incremental search of link in tinymce should be localizable

Reported by: Toro_Unit Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch needs-refresh
Focuses: Cc:

Description

related: #44541

Incremental search of link in tinymce should fire from 2 chars in Japanese. These fixes are included in the WP Multibyte Patch plugin in the Japanese package.

So, the number should be localizable.

Attachments (4)

44662.patch (1.7 KB) - added by Toro_Unit 12 months ago.
44662.2.patch (1.8 KB) - added by Toro_Unit 12 months ago.
Add comment for translators.
44662.3.patch (1.8 KB) - added by Toro_Unit 12 months ago.
44662.4.patch (2.2 KB) - added by Toro_Unit 10 months ago.

Download all attachments as: .zip

Change History (13)

@Toro_Unit
12 months ago

#1 @miyauchi
12 months ago

This is a one of a series of patches to fix problems for Japanese package.

Related: #meta3163, #43829, #44296, #44541, #15955, #22363, #44548

@Toro_Unit
12 months ago

Add comment for translators.

#3 @swissspidy
12 months ago

IMHO this also needs a context that's better to understand than search internal links. Something like minimum search input word length or so.

@Toro_Unit
12 months ago

#4 @Toro_Unit
12 months ago

Hi @swissspidy

Thanks for your review.

i fixed to make it easier to understand that search starts from the 3rd character.

https://core.trac.wordpress.org/attachment/ticket/44662/44662.3.patch

#5 @ocean90
10 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.0

Thanks for the patch! A few suggestions:

  • Let's try to reduce the context to 5-6 words
  • Cast the value to an integer ((int) _x( … ))
  • Provide a fallback if (int) _x( … ) returns 0

@Toro_Unit
10 months ago

#6 @Toro_Unit
10 months ago

@ocean90 Thank you Review!

add new patch. https://core.trac.wordpress.org/attachment/ticket/44662/44662.4.patch

add fallback for _x( … ) return 0 or not number value.

#7 @peterwilsoncc
9 months ago

  • Milestone changed from 5.0 to 5.1

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

#8 @pento
6 months ago

  • Milestone changed from 5.1 to 5.2

This ticket needs a review and decision.

#9 @desrosj
4 months ago

  • Milestone changed from 5.2 to 5.3

This has not seen any action during the 5.2 cycle. Punting to 5.3 since 5.2 beta 1 is fast approaching.

Note: See TracTickets for help on using tickets.