Text length of the Incremental search of link in tinymce should be localizable

[Toro_Unit]

related: #44541

Incremental search of link in tinymce should fire from 2 chars in Japanese. These fixes are included in the WP Multibyte Patch plugin in the Japanese package.

So, the number should be localizable.

[miyauchi]

This is a one of a series of patches to fix problems for Japanese package.

Related: ​#meta3163, #43829, #44296, #44541, #15955, #22363, #44548

[miyauchi]

Following is a list of tickets to improve multibyte enhancement.

​https://docs.google.com/spreadsheets/d/13oGbc7AqEN6OUvmze-JDCKXDdruFqsxqSAdI7-b6Lho/edit#gid=0

[Toro_Unit]

Add comment for translators.

[swissspidy]

IMHO this also needs a context that's better to understand than search internal links. Something like minimum search input word length or so.

[Toro_Unit]

Hi @swissspidy

Thanks for your review.

i fixed to make it easier to understand that search starts from the 3rd character.

https://core.trac.wordpress.org/attachment/ticket/44662/44662.3.patch

[ocean90]

Thanks for the patch! A few suggestions:

• Let's try to reduce the context to 5-6 words
• Cast the value to an integer ((int) _x( … ))
• Provide a fallback if (int) _x( … ) returns 0

[Toro_Unit]

@ocean90 Thank you Review!

add new patch. https://core.trac.wordpress.org/attachment/ticket/44662/44662.4.patch

add fallback for _x( … ) return 0 or not number value.

[peterwilsoncc]

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

[pento]

This ticket needs a review and decision.

[desrosj]

This has not seen any action during the 5.2 cycle. Punting to 5.3 since 5.2 beta 1 is fast approaching.

[birgire]

The patch 44662-5.diff​ is a minor refresh that

1) Replaces the typo serchLength with searchLength.

2) Fixes the PHPCS issue:

 1395 | ERROR | [x] Expected 1 space after closing brace; newline found

3) Replaces the for part in variables:

$minimum_word_length_for_search 
minimumWordLengthForSearch

with:

$minimum_search_word_length
minimumSearchWordLength

4) Combines the variable defining parts of patch 44662.4.patch​

I tested this by increasing the minimum search word length to 5 (instead of 3) in the patch and that seems to work as expected on my test install.

[davidbaumwald]

@SergeyBiryukov Is this ready for 5.3 Beta 1 by tomorrow?

[desrosj]

Unfortunately, with beta 1 in a few hours, this needs to be punted.

[SergeyBiryukov]

In 46988:

I18N: Make the minimum input length to start searching posts in the "Insert/edit link" modal localizable.

Props Toro_Unit, birgire, miyauchi, swissspidy, ocean90.
Fixes #44662.