WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#44668 closed defect (bug) (fixed)

Twenty Sixteen: Implement preconnect for Google Fonts

Reported by: westonruter's profile westonruter Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.6
Component: Bundled Theme Keywords: has-patch
Focuses: performance Cc:

Description

Previously #37171. It seems Twenty Sixteen was left out when adding resource hints for Google Fonts. All other core themes have it, including Twenty Seventeen.

Attachments (1)

44668.0.diff​ (1.0 KB) - added by westonruter 6 years ago.

Download all attachments as: .zip

Change History (12)

@westonruter
6 years ago

#1 @westonruter
6 years ago

  • Focuses performance added
  • Keywords has-patch added
  • Owner set to peterwilsoncc
  • Status changed from new to reviewing
  • Summary changed from Implement preconnect to Google fonts in Twenty Sixteen to Implement preconnect for Google Fonts in Twenty Sixteen

#2 @peterwilsoncc
6 years ago

Thanks Weston, I’ve set a reminder to review this when I return from vacation mid-August

#3 @SergeyBiryukov
6 years ago

  • Summary changed from Implement preconnect for Google Fonts in Twenty Sixteen to Twenty Sixteen: Implement preconnect for Google Fonts

#4 @peterwilsoncc
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 43606:

Twenty Sixteen: Add pre-connect resource hint for Google Fonts.

When using Google Fonts, pre-connect to ​https://fonts.gstatic.com to improve the performance downloading the webfont files.

Props westonruter.
Fixes #44668.

#5 @peterwilsoncc
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 4.9 branch.

#6 @peterwilsoncc
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43607:

Twenty Sixteen: Add pre-connect resource hint for Google Fonts.

When using Google Fonts, pre-connect to ​https://fonts.gstatic.com to improve the performance downloading the webfont files.

Props westonruter.
Merges [43606] to the 4.9 branch.
Fixes #44668.

#7 @pento
6 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.9.9 to 5.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

This needs to be reverted from the 4.9 branch.

#8 @pento
6 years ago

  • Milestone changed from 5.1 to 4.9.9

Leaving it in 4.9.9 for now, so we don't forget to revert it. It can be moved to the 5.1 milestone after that.

#9 @SergeyBiryukov
6 years ago

In 43698:

Twenty Sixteen: Revert [43607] from the 4.9 branch.

This change is out of the 4.9.x scope, and will be reintroduced in 5.1.x.

See #44668.

#10 @SergeyBiryukov
6 years ago

  • Milestone changed from 4.9.9 to 5.1

#11 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.