WordPress.org

Make WordPress Core

Opened 11 months ago

Last modified 3 months ago

#44669 assigned defect (bug)

Privacy Notification doesn't clear after dismissing notification

Reported by: ahortin Owned by: garrett-eclipse
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.9.7
Component: Privacy Keywords: needs-patch
Focuses: Cc:

Description

Every time the 'Suggested privacy policy text' is changed, the Settings > Privacy page displays a notification. Clicking the Close (x) icon doesn't clear the notification. If I navigate away from the page, the Privacy Policy notification reappears. The only way to clear the notification is to click the review the guide link.

If a site has a custom privacy policy page, like most typical business sites, then they shouldn't be forced to view this page every time it changes as it's not going to be relevant to them. The Close icon should clear the notification in the same way that clicking the review the guide link does.

Screenshot: https://cl.ly/3r0Y3m0P452X

Attachments (1)

privacy_notification.png (120.9 KB) - added by birgire 9 months ago.
Attached the screenshot, just in case the external screenshot link goes down.

Download all attachments as: .zip

Change History (30)

#1 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to 4.9.9

#2 @desrosj
11 months ago

  • Keywords needs-patch added

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


11 months ago

#4 follow-up: @norcross
11 months ago

I believe the UI has changed a bit, but the same issue is presented on the post editor itself. I'm happy to write the patch, but curious if anyone has a preferred approach (ajax call + option setting?)

example: https://www.dropbox.com/s/vfoqd6snlw7iprs/privacy-guide-notice.png?dl=0

#5 @idea15
10 months ago

  • Owner set to javorszky
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


9 months ago

@birgire
9 months ago

Attached the screenshot, just in case the external screenshot link goes down.

#7 in reply to: ↑ 4 @garrett-eclipse
9 months ago

Replying to norcross:

I believe the UI has changed a bit, but the same issue is presented on the post editor itself. I'm happy to write the patch, but curious if anyone has a preferred approach (ajax call + option setting?)

example: https://www.dropbox.com/s/vfoqd6snlw7iprs/privacy-guide-notice.png?dl=0

Thanks @norcross, patches are always appreciated

The example you provided is a unique notice from the one discussed in this ticket so I've created a unique one for your concern. I'd love your thoughts and input there.
Ticket - #44981

#8 @garrett-eclipse
9 months ago

As to the behaviour of the notice on the Privacy Settings page this ticket discusses I wonder if this would make more sense as custom code or plugin land as disabling the notice completely is a single line;

<?php
remove_action( 'admin_notices', array( 'WP_Privacy_Policy_Content', 'policy_text_changed_notice' ) );

For the basic user who hasn't gotten their policy created professionally the nag is a helpful prompt to understand their Privacy coverage has changed.

That aside if it's deemed this moves forward an AJAX call would have to be added on a $document.on( 'click', '.policy-text-updated.is-dismissable .notice-dismiss'... to force the update of _wp_suggested_privacy_policy_content post meta content so as to make $new == $old as this is how the text_change_check is handled;
https://github.com/WordPress/WordPress/blob/f7ba175491b725a5f3d636072c8b432774d38ae3/wp-admin/includes/misc.php#L1345-L1417

#9 @garrett-eclipse
9 months ago

I was going to propose the Dismiss Privacy Nag plugin - https://wordpress.org/plugins/dismiss-privacy-nag/
But that is for the pointer and doesn't cover this specific case

#10 @pento
9 months ago

  • Milestone changed from 4.9.9 to Future Release

This ticket was mentioned in Slack in #core-privacy by webdevlaw. View the logs.


9 months ago

#12 @desrosj
7 months ago

  • Owner javorszky deleted

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


7 months ago

#14 @garrett-eclipse
7 months ago

  • Owner set to garrett-eclipse

#15 @pento
3 months ago

  • Keywords needs-design added
  • Milestone changed from Future Release to 5.2

I'm moving this ticket into the 5.2 milestone, as we need a better way of handling suggested policy changes. [44987] made some minor changes to the default policy text, which will cause this menu bubble to appear on every site, even though no-one actually needs to update their own policy to match, or even review the changed wording.

Thinking about this some more, I don't know that a menu bubble is really the appropriate level of notification for privacy policy updates. I understand that this is the toned down version, it was originally an admin notice. But, despite being quite small, it stands out a lot, drawing attention away from whatever the person is actually trying to do. These notifications should really only be used for things that are immediately actionable, I suspect that privacy policy text changes are anything but that.

I'm also tagging this ticket for design review, let's look at how we can improve this.

#16 @garrett-eclipse
3 months ago

Thanks for the feedback @pento I'll raise it in today's #core-privacy meeting.

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

#19 @karmatosed
3 months ago

One possible approach that comes to mind would be to have a 'what's changed' notice section in the privacy section. This could act as a call out for any updates.

#20 @timhibberd
3 months ago

I am testing on 5.2-beta1-45072 and I can't get rid of the little red icon stuck to the Settings and Settings/Privacy admin menu items. There does not seem to be any action on the page that I am being asked to action.Am I missing something?

Cheers :-)

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

This ticket was mentioned in Slack in #themereview by jarretc. View the logs.


3 months ago

#24 @poena
3 months ago

I am experiencing the same in 5.2-beta1-45111.

No action that I have tried changes the status of the icon.
I have selected a page, published it, removed it, created a new page, published it and assigned it to a menu.

Last edited 3 months ago by poena (previous) (diff)

This ticket was mentioned in Slack in #core-privacy by swissspidy. View the logs.


3 months ago

#26 @garrett-eclipse
3 months ago

Hi Everyone, sorry for the delay in updating the ticket here. @pento thanks for the initial flag here.

This issue has come up in the last couple of #core-privacy meetings with the following path forward discussed and tentatively agreed upon (further input always welcome).

  1. Strip the bubble

*To expedite this item I've created #46819 and uploaded a patch to remove this bubble.

  1. Re-introduce the notice
  2. Isolate the notice to specific sections
  3. Introduce dismissible functionality
  4. Add it to each notice
  5. Introduce auto-restore functionality so when a privacy policy change occurs the ‘dismiss’ goes away returning the notice

*This is a trim downed version of the original - https://wordpress.slack.com/archives/C9695RJBW/p1554135580070600

Aside from the bubble removal (#46819) and work on dismissible privacy notices (this ticket & #44981) there was @karmatosed's thought on a what's changed section which reminds me of #44538 that was also discussed in the aforementioned #core-privacy meetings.
Summary;

  • Currently, no clear way of indicating what's actually changed.
  • Core already has diff functionality which can be leveraged
  • Open Question: Should we gather 'all' revisions of the privacy policy guide like proper post types or just compare the previous to the current.

*There's pros and cons to both so feedback welcome either way.

  • Design can be improved now that accordions are part of core

*Initial mockups of the privacy policy guide used mockups to reduce page height but were avoided due to minor restrictions at the time.
*The accordion approach may also mean splitting up the core policy text into more easily digestible and potentially filterable chunks like 'Comments', 'Cookies' and 'Analytics'.
Start of Slack Discussion - https://wordpress.slack.com/archives/C9695RJBW/p1553715193535000

I hope I've covered everything and am just pinging @xkon and @pepe as they were part of the discussion as well as @swissspidy as he also flagged the bubble issue. If I've overlooked anything please update this ticket.

All the best

#27 @garrett-eclipse
3 months ago

  • Keywords needs-design removed
  • Milestone changed from 5.2 to 5.3

As the critical issue (privacy bubble) will be handled via #46819 I'm moving this to 5.3 in order to address it in conjunction with a way to identify changes as proposed above and in #44538 which will require design input.

#28 follow-up: @timhibberd
3 months ago

Cheers for the update @garrett-eclipse.

My 2 cents worth regarding your open question is as follows:

1) Manually Created Change Excerpt with a link to an auto-generated page delta:

Privacy page administrator should have an excerpt box to manually summarise the privacy page changes from an end-user impact perspective (like a Git Commit comment). It is common in the industry for end-users to receive a privacy document change summary in addition to the revised privacy document. A changed privacy document will show what has changed but does not necessarily instruct the reader as to the impact of the changes...the "why". The change notice excerpt presented to the user would have a link to the auto-generated page delta.

2) Changes should be aggregated from the last time the user logged in. If a user does not log in for a while and multiple changes have occured then the user should be presented with all the changes since they last logged in.

3) I am assuming that the privacy page notice will appear as banner bar and / or via API so the theme designer can present it in a theme-appropriate fashion and in an accessibility conformant fashion? Displaying a notice on the admin dashboard would only be of value to site administrators on a multi-site network. None of the client sites I manage show any of the admin constructs to end-users (e.g. no toolbar). So I would anticipate hooking a callback function to present the privacy change info to the user in an appropriate spot on the page they are looking at when they log in.

Thanks for all your hard work. Much appreciated :-)

#29 in reply to: ↑ 28 @garrett-eclipse
3 months ago

Thanks @timhibberd I greatly appreciate the feedback and have posted it over to 44538#comment:12 so it will be taken into account when work on that feature is picked up.
Cheers

Note: See TracTickets for help on using tickets.