Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#44680 closed enhancement (fixed)

Restrict the Try Gutenberg callout audience

Reported by: pento's profile pento Owned by: pento's profile pento
Milestone: 4.9.8 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch fixed-major
Focuses: administration Cc:

Description

As exciting as it would be to put Gutenberg in front of every WordPress users on the planet, we can start a little smaller, and ramp up in future releases.

To begin with, let's go with these categories:

  • When Gutenberg is either not installed, or not activated, only show the callout to users with the install_plugins capability.
  • When Gutenberg is activated, expand that to include all users with the edit_posts capability.

Attachments (1)

44680.diff (934 bytes) - added by pento 6 years ago.

Download all attachments as: .zip

Change History (9)

@pento
6 years ago

#1 @danieltj
6 years ago

I'm not being sarcastic or insincere here; thank you for this. I'm very pleased to see this issue addressed.

It concerned me a lot, the possibility of showing the callout to everyone.

Version 0, edited 6 years ago by danieltj (next)

#2 @pento
6 years ago

44680.diff is ready for commit with sign off from another committer.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


6 years ago

#4 @jorbin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43543:

Gutenberg: Restrict "Try Gutenberg" based on capability and gutenstatus

When Gutenberg is either not installed, or not activated, only show the callout to users with the install_plugins capability.
When Gutenberg is activated, expand that to include all users with the edit_posts capability.

Props pento.
Fixes #44680.

#5 @jorbin
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @jorbin
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43544:

Gutenberg: Restrict "Try Gutenberg" based on capability and gutenstatus

When Gutenberg is either not installed, or not activated, only show the callout to users with the install_plugins capability.
When Gutenberg is activated, expand that to include all users with the edit_posts capability.

4.9 branch commit.

Props pento.
Fixes #44680.

#7 @jorbin
6 years ago

In 43545:

Gutenbeg: you can't remove call outs that don't exist

This commit should have just gone into the 4.9 branch. It did in [43544].

See: #44680
Unprops jorbin
props ocean90

This ticket was mentioned in Slack in #core-editor by pbiron. View the logs.


6 years ago

Note: See TracTickets for help on using tickets.