Expired validation links do not always correctly trigger errors

[desrosj]

When a user clicks a confirmaction link for a privacy request and the request is not pending or failed, it should return an error saying This link has expired.. Currently, the error message is being returned as a string and not as a WP_Error instance. This is causing a success message to display to the user instead of the correct error message.

[SergeyBiryukov]

#44686 was marked as a duplicate.

[SergeyBiryukov]

Related: #44298

[desrosj]

This is good to go.

[SergeyBiryukov]

In 43623:

Privacy: When clicking a confirmation link for a privacy request, return a WP_Error object if the link has expired.

Returning a string caused a success message to be displayed instead of the correct error message.

Props desrosj.
Fixes #44685.

[SergeyBiryukov]

In 43624:

Privacy: When clicking a confirmation link for a privacy request, return a WP_Error object if the link has expired.

Returning a string caused a success message to be displayed instead of the correct error message.

Props desrosj.
Merges [43623] to the 4.9 branch.
Fixes #44685.

[pento]

[43624] needs to be reverted from the 4.9 branch, then this ticket can be moved to the 5.0.1 milestone.

[SergeyBiryukov]

In 43708:

Privacy: Revert [43624] from the 4.9 branch.

This change is out of the 4.9.x scope, and will be reintroduced in 5.0.x.

See #44685.

[desrosj]

@maxbomb Can I ask why this was closed? This is a confirmed bug that has a working patch and has been moved to the 5.0.1 milestone.

[desrosj]

Let's leave this in 5.1. It falls outside of the 5.0.3 scope.