WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#44685 closed defect (bug) (fixed)

Expired validation links do not always correctly trigger errors

Reported by: desrosj's profile desrosj Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch
Focuses: Cc:

Description

When a user clicks a confirmaction link for a privacy request and the request is not pending or failed, it should return an error saying This link has expired.. Currently, the error message is being returned as a string and not as a WP_Error instance. This is causing a success message to display to the user instead of the correct error message.

Attachments (1)

44685.diff​ (459 bytes) - added by desrosj 7 years ago.

Download all attachments as: .zip

Change History (16)

@desrosj
7 years ago

#1 @SergeyBiryukov
7 years ago

#44686 was marked as a duplicate.

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.
7 years ago

#4 @desrosj
7 years ago

  • Keywords commit added

This is good to go.

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.
6 years ago

#6 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43623:

Privacy: When clicking a confirmation link for a privacy request, return a WP_Error object if the link has expired.

Returning a string caused a success message to be displayed instead of the correct error message.

Props desrosj.
Fixes #44685.

#7 @SergeyBiryukov
6 years ago

In 43624:

Privacy: When clicking a confirmation link for a privacy request, return a WP_Error object if the link has expired.

Returning a string caused a success message to be displayed instead of the correct error message.

Props desrosj.
Merges [43623] to the 4.9 branch.
Fixes #44685.

#8 @pento
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[43624] needs to be reverted from the 4.9 branch, then this ticket can be moved to the 5.0.1 milestone.

#9 @SergeyBiryukov
6 years ago

In 43708:

Privacy: Revert [43624] from the 4.9 branch.

This change is out of the 4.9.x scope, and will be reintroduced in 5.0.x.

See #44685.

#10 @SergeyBiryukov
6 years ago

  • Milestone changed from 4.9.9 to 5.0.1

#11 @maxbomb
6 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed

#12 @desrosj
6 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@maxbomb Can I ask why this was closed? This is a confirmed bug that has a working patch and has been moved to the 5.0.1 milestone.

#13 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#14 @pento
6 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#15 @desrosj
6 years ago

  • Keywords commit removed
  • Milestone changed from 5.0.3 to 5.1
  • Resolution set to fixed
  • Status changed from reopened to closed

Let's leave this in 5.1. It falls outside of the 5.0.3 scope.

Note: See TracTickets for help on using tickets.