#44691 closed defect (bug) (fixed)
Comment variable is wrong for shortcode tags
| Reported by: | uttam007 | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | Shortcodes | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Filters the list of shortcode tags to remove from the content comment variable is not correct. It should be $tags_to_remove instead of $tag_array.
Attachments (2)
Change History (7)
#1
@
8 years ago
- Keywords has-patch needs-refresh added
- Milestone Awaiting Review → 5.0
Hi @uttam007, welcome to Trac and thanks for creating his ticket :)
Could you refresh the patch please so that the @param's descriptions are aligned:
-
src/wp-includes/shortcodes.php
function strip_shortcodes( $content ) { 609 609 * 610 610 * @since 4.7.0 611 611 * 612 * @param array $tag _arrayArray of shortcode tags to remove.613 * @param string $content Content shortcodes are being removed from.612 * @param array $tags_to_remove Array of shortcode tags to remove. 613 * @param string $content Content shortcodes are being removed from. 614 614 */ 615 615 $tags_to_remove = apply_filters( 'strip_shortcodes_tagnames', $tags_to_remove, $content );}}}
#2
follow-up:
↓ 3
@
8 years ago
- Component General → Shortcodes
Please mention your version of WordPress where you found the issue. And curious to know about the name of your diff file. It has 7361 in it. Usually the diffs are created with the ticket number like 44691.diff. Any specific reason?
#3
in reply to: ↑ 2
@
8 years ago
Replying to subrataemfluence:
I have uploaded another attachment with the ticket number and the Wordpress version is 4.9.7.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Updated the comment parameter name in the comment.