Opened 7 years ago
Closed 6 years ago
#44699 closed defect (bug) (fixed)
Twenty Seventeen: Comment form cookies consent checkbox has no focus style
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.0.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch fixed-5.0 |
Focuses: | accessibility | Cc: |
Description
In Twenty Seventeen, the new checkbox in the comments form to consent to cookies has no focus style at all. While the other fields use a slightly darker border (see the field "Website|" in the screenshot below), the there's no specific focus style for checkboxes.
The outline is reset to 0 so, at least in Chrome, Safari, and Opera on mac, there's no indication of focus on the checkbox. Firefox applies some native style.
Seems Twenty Sixteen and Fifteen are OK, as they apply some focus style to checkboxes.
Attachments (5)
Change History (20)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
6 years ago
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
6 years ago
#7
@
6 years ago
- Keywords ui-feedback removed
As there's a working (and tested) patch and it seems this doesn't need direct design feedback, the design team thinks this one's good to go :)
#10
@
6 years ago
- Status changed from reviewing to accepted
Thanks for the report, @afercia, and for the patch, @pratikthink!
This update looks good to me, as long as the difference is visually sufficient -- I'm not really an expert there :) @afercia do you mind taking a peek at the screenshots I've attached, and confirming? I'd really appreciate your expertise on this!
#11
@
6 years ago
@laurelfulford @pratikthink thanks! Looks good to me, as it replicates the native Firefox focus style.
I tested the patch and it looks ok on my side.
Adding ui-feedback but I think it can probably lands in 4.9.9.