WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#44717 closed defect (bug) (fixed)

Missing space in changelog on about.php

Reported by: swissspidy Owned by: SergeyBiryukov
Milestone: 5.0 Priority: lowest
Severity: trivial Version: 4.9.8
Component: Help/About Keywords: has-patch fixed-5.0
Focuses: administration Cc:

Description

On wp-admin/about.php there's a missing space after the period for the 4.9.8 changelog entry:

Version 4.9.8 addressed 46 bugs.For more information, see the release notes.

Screenshot: https://cloudup.com/cEPPqwWZeE0

Attachments (2)

44717.patch (1.8 KB) - added by burhandodhy 3 years ago.
One possible solution is to add extra space after the line end
44717.diff (675 bytes) - added by chetan200891 3 years ago.
Created patch to add missing space.

Download all attachments as: .zip

Change History (13)

@burhandodhy
3 years ago

One possible solution is to add extra space after the line end

#1 @swissspidy
3 years ago

@burhandodhy To be clear, the space is only missing for the latest changelog entry (4.9.8). All other strings are fine and the space is not within the translatable strings. There's no need to change the strings and force all the translators to update their packages.

It's the way the strings are concatenated that somehow differs for 4.9.8. This just needs be adjusted.

Notice the difference by comparing [43552] and [43407].

@chetan200891
3 years ago

Created patch to add missing space.

#2 @chetan200891
3 years ago

@swissspidy I have created patch 44717.diff to fix missing space issue.

#3 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Help/About
  • Focuses administration added
  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.9.9

#4 @desrosj
3 years ago

  • Keywords needs-refresh added

@chetan200891 the patch fixes the issue for me. Can you refresh the patch to keep the code formatted with multiple lines so that it remains consistent with the other printf() calls in the file?

#5 @desrosj
3 years ago

  • Keywords commit added; needs-refresh removed

Actually, my mistake. It is consistent with the other release "For more information" links. Looks good to me.

#6 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43622:

Help/About: Ensure the space after the period for the 4.9.8 changelog entry is preserved.

Props chetan200891, burhandodhy, swissspidy.
Fixes #44717.

This ticket was mentioned in Slack in #core by chetan200891. View the logs.


3 years ago

#8 @danielbachhuber
3 years ago

  • Milestone changed from 4.9.9 to 5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

[43622] needs backport against 5.0

#9 @danielbachhuber
3 years ago

In 43772:

Help/About: Ensure the space after the period for the 4.9.8 changelog entry is preserved.

Props chetan200891, burhandodhy, swissspidy.
Merges [43622] to the 5.0 branch.
See #44717.

#10 @danielbachhuber
3 years ago

  • Keywords fixed-5.0 added; commit removed

#11 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.