WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 15 months ago

#44719 new defect (bug)

Hide this update button placement is wrong on update-core.php

Reported by: subrataemfluence Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch
Focuses: ui Cc:
PR Number:

Description

The button Hide this update in update-core.php is wrongly placed. There should be a small space after Update Now button.

Please see screenshot

Attachments (4)

screenshot.png (9.3 KB) - added by subrataemfluence 15 months ago.
44719.diff (563 bytes) - added by subrataemfluence 15 months ago.
Proposed patch
with-patch.png (11.8 KB) - added by subrataemfluence 15 months ago.
After applying proposed patch
44719.2.diff (950 bytes) - added by chetan200891 15 months ago.
Created patch to fix space issue.

Download all attachments as: .zip

Change History (8)

@subrataemfluence
15 months ago

Proposed patch

@subrataemfluence
15 months ago

After applying proposed patch

#1 @subrataemfluence
15 months ago

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
15 months ago

  • Keywords needs-patch added; has-patch removed
  • Version 4.9.8 deleted

I wonder where these styles got lost...

In any case, we shouldn't fix this with inline styles but by putting some proper selectors in a CSS file.

@chetan200891
15 months ago

Created patch to fix space issue.

#3 @chetan200891
15 months ago

I have created patch 44719.2.diff to fix space issue.

Last edited 15 months ago by chetan200891 (previous) (diff)

#4 @subrataemfluence
15 months ago

@chetan200891 there are many areas in core where inline styles have been used specially where elements are not being reused anywhere else.

Since Hide Update button is only available on update-core.php and not being used anywhere else I thought its better to have it inline rather than introducing another CSS class.

I may be wrong!

Note: See TracTickets for help on using tickets.