Make WordPress Core

Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#44719 closed defect (bug) (invalid)

Hide this update button placement is wrong on update-core.php

Reported by: subrataemfluence's profile subrataemfluence Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: ui, css Cc:

Description

The button Hide this update in update-core.php is wrongly placed. There should be a small space after Update Now button.

Please see screenshot

Attachments (4)

screenshot.png (9.3 KB) - added by subrataemfluence 6 years ago.
44719.diff (563 bytes) - added by subrataemfluence 6 years ago.
Proposed patch
with-patch.png (11.8 KB) - added by subrataemfluence 6 years ago.
After applying proposed patch
44719.2.diff (950 bytes) - added by chetan200891 6 years ago.
Created patch to fix space issue.

Download all attachments as: .zip

Change History (12)

@subrataemfluence
6 years ago

Proposed patch

@subrataemfluence
6 years ago

After applying proposed patch

#1 @subrataemfluence
6 years ago

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
6 years ago

  • Keywords needs-patch added; has-patch removed
  • Version 4.9.8 deleted

I wonder where these styles got lost...

In any case, we shouldn't fix this with inline styles but by putting some proper selectors in a CSS file.

@chetan200891
6 years ago

Created patch to fix space issue.

#3 @chetan200891
6 years ago

I have created patch 44719.2.diff fix space issue.

Version 0, edited 6 years ago by chetan200891 (next)

#4 @subrataemfluence
6 years ago

@chetan200891 there are many areas in core where inline styles have been used specially where elements are not being reused anywhere else.

Since Hide Update button is only available on update-core.php and not being used anywhere else I thought its better to have it inline rather than introducing another CSS class.

I may be wrong!

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

#6 @davidbaumwald
3 years ago

  • Focuses css added

#7 @helen
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

This ticket came up by accident but closing because I don't see it as of 5.6-beta4. #dismiss/#undismiss picked up a margin somewhere along the way.

#8 @sabernhardt
3 years ago

  • Keywords needs-patch removed

The margin was added in [42785]

Note: See TracTickets for help on using tickets.