WP_Query: in searches post_status should consider exclude_from_search

[felipeelia]

When post_status is empty and we are running a search, this code is executed (wp-includes/class-wp-query.php:2446):

// Add public states.
$public_states = get_post_stati( array( 'public' => true ) );
foreach ( (array) $public_states as $state ) {
        if ( 'publish' == $state ) { // Publish is hard-coded above.
                continue;
        }
        $where .= " OR {$wpdb->posts}.post_status = '$state'";
}

That way the exclude_from_search parameter isn't considered.

[casepress]

update test

[davidbaumwald]

This ticket was discussed during 5.3 Bug Scrub 1. Since this possible alters search results, this should be communicated with a dev note.

[davidbaumwald]

@SergeyBiryukov How do you feel about this one landing in 5.3? Is there anything esle you need to make that happen?

[davidbaumwald]

With 5.3 RC1 releasing today, this ticket is being moved to Future Release. If any committer feels this can be worked in quickly for 5.3 or can assume ownership in 5.4, feel free to move it back up.

[SergeyBiryukov]

Related: #48556