WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 3 months ago

#44743 closed defect (bug) (wontfix)

Try Gutenberg Callout: broken UI when clicking multiple times on Install Classic Editor

Reported by: mathieuhays Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.8
Component: Administration Keywords: has-screenshots
Focuses: ui Cc:
PR Number:

Description

Steps to reproduce:

  1. Click on "Install Classic Editor"
  2. Button changes to "Installing..."
  3. Click again on the button (nothing visual happens at that point, still installing)
  4. Button changes to "Activate Classic Editor" with the progress icon (rotating arrows) still showing. An error message is also displayed mentioning the directory already exist.

How to fix:

Prevent the button callback to send another install request if it's already installing.

Attachments (2)

Screen Shot 2018-08-06 at 15.30.38.png (102.9 KB) - added by mathieuhays 15 months ago.
Try Gutenberg Callout: Broken UI
44743-try-gutenberg-error.PNG (57.2 KB) - added by ianbelanger 15 months ago.
Try Gutenberg Install Classic Editor error

Download all attachments as: .zip

Change History (6)

@mathieuhays
15 months ago

Try Gutenberg Callout: Broken UI

#1 @ianbelanger
15 months ago

  • Keywords has-screenshots needs-patch added

I can confirm that this issue exists. Screenshot coming

@ianbelanger
15 months ago

Try Gutenberg Install Classic Editor error

#2 @subrataemfluence
15 months ago

  • Keywords dev-feedback added

A possible solution could be if we can make the button non-clickable further during the installation is in progress like @mathieuhays suggested.

Prevent the button callback to send another install request if it's already installing.

The problem this is not a button, a hyperlink instead. So we cannot use conventional disable attribute here.

Using CSS3 property pointer-events: none along with a cursor: default; had worked for me in both Chrome and Firefox.

File: /wp-admin/js/updates.js

wp.updates.installPlugin = function( args ) {
   [...]
   if( 'dashboard' === pagenow && 'classic-editor' === args.slug ) {
      $message.attr( 'style', 'pointer-events: none; cursor: default;' );
   }
   [...]
}

#3 @SergeyBiryukov
15 months ago

  • Component changed from General to Administration
  • Focuses ui added

#4 @garrett-eclipse
3 months ago

  • Keywords needs-patch dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As the Try Gutenberg Callout was deprecated in WP5.0 I'm going to close this as no longer applicable.
Changeset - https://core.trac.wordpress.org/changeset/44106

Note: See TracTickets for help on using tickets.