Dashboard - Dismiss close button hover effect should be consistent

[krupajnanda]

The Dismiss close button shows red color normally for hover effect but for the hover effect is missing for

.try-gutenberg-panel

class.

[krupajnanda]

Please check this visual for more detail.

[subrataemfluence]

Good catch! Proposed patch uploaded.

[mukesh27]

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

[mukesh27]

Try this patch to add css in both files.

[subrataemfluence]

Sorry for the mistake! I will asap.

[subrataemfluence]

Since you have already uploaded it I need not to do it again! Thank you for correcting me.

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

[SergeyBiryukov]

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

Actually, minified files should not be patched, they are auto-generated by the build tools. There's a ​SCRIPT_DEBUG constant you can add to your wp-config.php file to use non-minified files.

So 44753.diff​ is enough, there's no mistake here. However, it would be helpful if the patch was created from the root directory and contained the full path: src/wp-admin/css/common.css, not just common.css.

[mukesh27]

@SergeyBiryukov thank you for your guidance. i know system create min version of CSS but for better understanding i have added both file in diff. i will take care of it in feature diff.

Replying to SergeyBiryukov:

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

Actually, minified files should not be patched, they are auto-generated by the build tools. There's a ​SCRIPT_DEBUG constant you can add to your wp-config.php file to use non-minified files.

So 44753.diff​ is enough, there's no mistake here. However, it would be helpful if the patch was created from the root directory and contained the full path: src/wp-admin/css/common.css, not just common.css.

[subrataemfluence]

@SergeyBiryukov thank you! Actually that's exactly what I thought about as well. As far as the path is concerned I will fix it and upload the modified one today.

[subrataemfluence]

@SergeyBiryukov Please let me know if 44753-2.diff is ok.

[subrataemfluence]

Modified. Please disregard 44753-2.diff

[pento]

Closing, as Try Gutenberg will be removed from the 4.9 branch.