WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#44753 closed defect (bug) (wontfix)

Dashboard - Dismiss close button hover effect should be consistent

Reported by: krupajnanda Owned by:
Milestone: Priority: normal
Severity: minor Version: 4.9.8
Component: Administration Keywords: ux-feedback has-screenshots has-patch
Focuses: ui, administration Cc:

Description

The Dismiss close button shows red color normally for hover effect but for the hover effect is missing for

.try-gutenberg-panel

class.

Attachments (5)

Dismiss close button hover effect is missing.gif (151.6 KB) - added by krupajnanda 2 years ago.
Please check this visual for more detail.
44753.diff (348 bytes) - added by subrataemfluence 2 years ago.
44753.patch (86.4 KB) - added by mukesh27 2 years ago.
Try this patch to add css in both files.
44753-2.diff (356 bytes) - added by subrataemfluence 2 years ago.
44753-3.diff (394 bytes) - added by subrataemfluence 2 years ago.
Modified. Please disregard 44753-2.diff

Download all attachments as: .zip

Change History (16)

@krupajnanda
2 years ago

Please check this visual for more detail.

#1 @subrataemfluence
2 years ago

  • Keywords has-patch added; needs-patch removed

Good catch! Proposed patch uploaded.

#2 follow-ups: @mukesh27
2 years ago

  • Component changed from General to Administration
  • Focuses administration added

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

@mukesh27
2 years ago

Try this patch to add css in both files.

#3 @subrataemfluence
2 years ago

Sorry for the mistake! I will asap.

#4 in reply to: ↑ 2 @subrataemfluence
2 years ago

Since you have already uploaded it I need not to do it again! Thank you for correcting me.

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

#5 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
2 years ago

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

Actually, minified files should not be patched, they are auto-generated by the build tools. There's a SCRIPT_DEBUG constant you can add to your wp-config.php file to use non-minified files.

So 44753.diff is enough, there's no mistake here. However, it would be helpful if the patch was created from the root directory and contained the full path: src/wp-admin/css/common.css, not just common.css.

#6 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9.9

#7 @SergeyBiryukov
2 years ago

  • Focuses ui added

#8 in reply to: ↑ 5 @mukesh27
2 years ago

@SergeyBiryukov thank you for your guidance. i know system create min version of CSS but for better understanding i have added both file in diff. i will take care of it in feature diff.

Replying to SergeyBiryukov:

Replying to mukesh27:

@subrataemfluence WordPress deskboar use min version of common css file and you have added patch for full version of css file.

Actually, minified files should not be patched, they are auto-generated by the build tools. There's a SCRIPT_DEBUG constant you can add to your wp-config.php file to use non-minified files.

So 44753.diff is enough, there's no mistake here. However, it would be helpful if the patch was created from the root directory and contained the full path: src/wp-admin/css/common.css, not just common.css.

#9 @subrataemfluence
2 years ago

@SergeyBiryukov thank you! Actually that's exactly what I thought about as well. As far as the path is concerned I will fix it and upload the modified one today.

#10 @subrataemfluence
2 years ago

@SergeyBiryukov Please let me know if 44753-2.diff is ok.

@subrataemfluence
2 years ago

Modified. Please disregard 44753-2.diff

#11 @pento
2 years ago

  • Milestone 4.9.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing, as Try Gutenberg will be removed from the 4.9 branch.

Note: See TracTickets for help on using tickets.