WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#44760 closed defect (bug) (fixed)

Media library module dates filter doesn't fully display

Reported by: ianbelanger Owned by: mikeschroder
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Media Keywords: has-screenshots has-patch needs-testing
Focuses: ui Cc:

Description

This issue first came up while testing Gutenberg. Here is the original ticket https://github.com/WordPress/gutenberg/issues/2202

The issue occurs when there is only one select box in the Media Modal. Basically the date filter select box text is getting cutoff. This currently only occurs when using Gutenberg, but there may be other cases where only one select box is shown in the Media Modal. The patch has already been committed into Gutenberg.

Once this is fixed in core, the commit should be removed from Gutenberg. https://github.com/WordPress/gutenberg/commit/8deaf5eca672848224e286e0ab03dde40fd5219d

Attachments (2)

gutenberg-2202.PNG (693.7 KB) - added by ianbelanger 3 years ago.
44760.diff (394 bytes) - added by ianbelanger 3 years ago.
Fixes the issue of the date filter select box being cutoff.

Download all attachments as: .zip

Change History (10)

@ianbelanger
3 years ago

Fixes the issue of the date filter select box being cutoff.

#1 @ianbelanger
3 years ago

  • Keywords has-patch added
  • Version set to trunk

This ticket was mentioned in Slack in #core-media by mike. View the logs.


3 years ago

#3 @mikeschroder
3 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.0

Thanks for the report and the patch!

We chatted about this in the media meeting, linked above, and folks agreed it should be fixed in core, so milestoning this to 5.0.

#4 @pento
3 years ago

  • Milestone changed from 5.0 to 5.1

This ticket was mentioned in Slack in #core-media by aaroncampbell. View the logs.


3 years ago

#6 @mikeschroder
3 years ago

  • Owner set to mikeschroder
  • Status changed from new to assigned

This applies still. From conversation in #core-media (linked above), seems it'd probably be okay to go ahead and fix this in core, then remove the rule from Gutenberg.

I'll double-test and consider for commit.

#7 @mikeschroder
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44653:

Media: Port date filter width fix from Gutenberg.

Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in https://github.com/WordPress/gutenberg/commit/8deaf5eca672848224e286e0ab03dde40fd5219d in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See https://github.com/WordPress/gutenberg/issues/2202

#8 @mikeschroder
3 years ago

Just a quick note that I haven't had the chance to submit a PR to Gutenberg to remove the CSS rule yet -- if no one gets to it before me, plan on doing this on Monday.

Note: See TracTickets for help on using tickets.