WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44761, comment 7


Ignore:
Timestamp:
01/27/2019 07:11:11 AM (9 months ago)
Author:
garrett-eclipse
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44761, comment 7

    initial v1  
    11Thanks for the report and initial patch @itowhid06. And @birgire I appreciate the additional case.
    22
    3 Attempting to apply the patch currently fails for trunk. Along with a refresh I'm wondering if we can move the translator comments within the multiline printf statements.
     3Attempting to apply the patch currently fails for trunk. Along with a refresh I'm wondering if we can move the translator comments within the multiline printf statements. [[BR]]
     4Example from Coding Standards - https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#multiline-function-calls
    45
    56I also feel the two instances of this translator comment could be made more explicit by indicating it's for the Privacy Policy page. [[BR]]