Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 8 years ago

Closed 8 years ago

#44764 closed defect (bug) (fixed)

Missing slash between protocol and domain in fallback of wp.api.utils.getRootUrl()

Reported by:	ocean90	Owned by:	kadamwhite
Priority:	normal	Milestone:	5.0
Component:	REST API	Version:	4.7
Severity:	normal	Keywords:	good-first-bug has-patch commit
Cc:		Focuses:	javascript, rest-api

Description

If window.location.origin isn't set, getRootUrl() falls back to window.location.protocol, a single slash and window.location.host. The result of this is an URL with one missing slash between the protocol and the domain because window.location.protocol only contains the protocol and the colon. Example output: http:/localhost:3000/

Attachments (2)

44764.1.diff (1.0 KB ) - added by abdullahramzan 8 years ago.: Slash Fix
44764.diff (438 bytes ) - added by kadamwhite 8 years ago.

Download all attachments as: .zip

Change History (10)

@abdullahramzan
8 years ago

Attachment 44764.1.diff added

Slash Fix

#1 @abdullahramzan
8 years ago

Keywords has-patch added; needs-patch removed

#2 @kadamwhite
8 years ago

Keywords needs-unit-tests added
Milestone Future Release → 5.0
Owner set to kadamwhite
Status new → accepted

@kadamwhite
8 years ago

Attachment 44764.diff added

This ticket was mentioned in Slack in #core-restapi by kadamwhite. View the logs.

8 years ago

#4 @kadamwhite
8 years ago

Refreshed patch to apply cleanly on the develop repo. Looks good, @abdullahramzan, thank you for tackling this!

#5 @kadamwhite
8 years ago

Keywords commit added; needs-unit-tests removed

#6 @kadamwhite
8 years ago

Resolution → fixed
Status accepted → closed

REST API: generate a valid fallback URI in wp.api.utils.getRootURL.

When window.location.origin isn't set, correctly insert two slashes between the protocol and host when constructing the fallback URL.

props abdullahramzan.
Fixes #44764.

#7 @SergeyBiryukov
8 years ago

Resolution fixed
Status closed → reopened

[43566] should be backported to the 5.0 branch.

#8 @danielbachhuber
8 years ago

Resolution → fixed
Status reopened → closed

REST API: generate a valid fallback URI in wp.api.utils.getRootURL.

When window.location.origin isn't set, correctly insert two slashes between the protocol and host when constructing the fallback URL.

Props abdullahramzan.
Merges [43566] into the 5.0 branch.
Fixes #44764.

Note: See TracTickets for help on using tickets.

Download in other formats: