WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#44785 closed defect (bug) (fixed)

css map file 404 since updating tinymce

Reported by: pross's profile pross Owned by: azaozz's profile azaozz
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

When tinymce was updated to 4.8 a map file reference was left at the end of the css file resulting in a 404.

wp-includes/js/tinymce/skins/lightgray/skin.min.css

Attachments (1)

44785.patch​ (86.1 KB) - added by pross 6 years ago.

Download all attachments as: .zip

Change History (9)

@pross
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to TinyMCE
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.9.9

Introduced in [43447]. Checked other files, this is the only one with a map reference.

#2 @azaozz
6 years ago

  • Keywords reporter-feedback added

Uh, that's from upstream. This is not a "big problem", the 404 happens only when loading TinyMCE with an open browser console (that supports CSS maps).

Wondering if it's worth it just removing that bit from the minified file (the 44785.patch) in 4.9.9 or waiting for the next TinyMCE update which may happen later.

#3 @pross
6 years ago

The other option of course is to build it with gulp and turn the maps off there.

#4 @azaozz
6 years ago

Well, this file comes from the ​TinyMCE project. Generally it is not a good idea to modify any external files, even a little. But in this case it seems the modification is really really benign :)

#5 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43581:

TinyMCE: remove stray CSS map reference from skin.min.css.

Props: pross.
Fixes #44785.

#6 @azaozz
6 years ago

  • Keywords commit fixed-major added; reporter-feedback removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.9.

#7 @pento
6 years ago

  • Milestone changed from 4.9.9 to 5.0

#8 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43787:

TinyMCE: remove stray CSS map reference from skin.min.css.

Merges [43581] to the 5.0 branch.

Props pross.
Fixes #44785.

Note: See TracTickets for help on using tickets.