Make WordPress Core

Opened 6 years ago

Last modified 6 months ago

#44790 new defect (bug)

Attachment Overlay does not trigger spinner for compat fields

Reported by: hjanuschka's profile hjanuschka Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch needs-testing needs-refresh close
Focuses: ui, javascript, administration Cc:


we are using ACF and some other custom fields in the attachment library, when we change values of those "compat" fields - the spinner/loader does not show up, which leads to the situation that the editor/user, may think everything is saved, and clicks assign/close to the overlay, and behind the overlay he/she may click on publish, which in some situations cancels the XHR requests and leads to data loss.

i have prepared a patch, not 100% sure if it is in the right place, let me know if you'd want me to adopt/change anything.

Attachments (2)

attachment_compat_indicator.44790.diff (1.3 KB) - added by hjanuschka 6 years ago.
attachment_compat_indicator.44790.1.diff (1.3 KB) - added by hjanuschka 6 years ago.
fix spaces

Download all attachments as: .zip

Change History (8)

#1 @hjanuschka
6 years ago

for whatever reason, the this.controller.trigger( 'attachment:compat:ready' and this.controller.trigger( 'attachment:compat:waiting' did not reach the this.listenTo( this.controller, 'attachment:compat:waiting attachment:compat:ready', this.updateSave );

those i change dit to the .on() variation, i found somwhere else in the js codebase

#2 @pento
5 years ago

  • Version trunk deleted

#3 @joemcgill
5 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.3

Hi @hjanuschka. Thanks for the report and for providing a patch. I'm going to move to the 5.3 milestone for testing/consideration.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.

5 years ago

#5 @davidbaumwald
5 years ago

  • Keywords needs-refresh added
  • Milestone changed from 5.3 to Future Release

The latest patch fails against trunk, so it needs a refresh. Also, this would need testing and review. With Beta 1 of version 5.3 only a few days away, this is being moved to Future Release. If this ticket can be resolved in time for 5.3, feel free to re-milestone.

#6 @joedolson
6 months ago

  • Keywords close added

This appears to be working in the current trunk; can you confirm whether you're still seeing this issue, @hjanuschka? For now, I'm marking this for potential close, if it's already fixed.

Note: See TracTickets for help on using tickets.