Attachment Overlay does not trigger spinner for compat fields

[hjanuschka]

we are using ACF and some other custom fields in the attachment library, when we change values of those "compat" fields - the spinner/loader does not show up, which leads to the situation that the editor/user, may think everything is saved, and clicks assign/close to the overlay, and behind the overlay he/she may click on publish, which in some situations cancels the XHR requests and leads to data loss.

i have prepared a patch, not 100% sure if it is in the right place, let me know if you'd want me to adopt/change anything.

[hjanuschka]

for whatever reason, the this.controller.trigger( 'attachment:compat:ready' and this.controller.trigger( 'attachment:compat:waiting' did not reach the this.listenTo( this.controller, 'attachment:compat:waiting attachment:compat:ready', this.updateSave );

those i change dit to the .on() variation, i found somwhere else in the js codebase

[hjanuschka]

fix spaces

[joemcgill]

Hi @hjanuschka. Thanks for the report and for providing a patch. I'm going to move to the 5.3 milestone for testing/consideration.

[davidbaumwald]

The latest patch fails against trunk, so it needs a refresh. Also, this would need testing and review. With Beta 1 of version 5.3 only a few days away, this is being moved to Future Release. If this ticket can be resolved in time for 5.3, feel free to re-milestone.

[joedolson]

This appears to be working in the current trunk; can you confirm whether you're still seeing this issue, @hjanuschka? For now, I'm marking this for potential close, if it's already fixed.

[karmatosed]

I also see this working, for now I am going to follow through and close this as the recommendation is there. We can always reopen if we get further steps on how to reproduce. Thank you everyone.