WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 2 weeks ago

#44793 reviewing defect (bug)

remove_accents() doesnt escape all versions of "i"

Reported by: bagosm Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Formatting Keywords: has-patch dev-feedback needs-testing
Focuses: Cc:

Description

The version with both dieresis and accent is missing. Suggested addition is the following

plus	                '΅Ι' => 'I', 'ΐ' => 'i',

Attachments (5)

44793.diff (260.0 KB) - added by sebastienserre 5 months ago.
44793-1.diff (411 bytes) - added by sebastienserre 5 months ago.
44793-2.diff (1.0 KB) - added by iamdmitrymayorov 5 months ago.
Added tests and relocated accents to the correct block under Greek Coptic.
44793-3.diff (1.0 KB) - added by iamdmitrymayorov 5 months ago.
Minor comment fix for previous patch
44793.4.diff (1.8 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (20)

#1 @sebastienserre
5 months ago

  • Keywords has-patch dev-feedback added

Hello @bagosm I've created a Patch with your modification. Many thanks to opened this ticket and improve WordPress.

#2 @sebastienserre
5 months ago

  • Component changed from General to Formatting

#3 @SergeyBiryukov
5 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 4.9.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Hi @bagosm, welcome to WordPress Trac! Thanks for the report.

@sebastienserre, thanks for the patch :) Could you please submit a patch without all the formatting changes?

#4 @sebastienserre
5 months ago

Hello @SergeyBiryukov HUuummm I don't know hos to do :-( I asked to PHPStorm to create a patch after my changes and it gave me this :-( I will check

#5 @sebastienserre
5 months ago

  • Keywords needs-refresh removed

Patch refreshed.

@iamdmitrymayorov
5 months ago

Added tests and relocated accents to the correct block under Greek Coptic.

#6 @iamdmitrymayorov
5 months ago

Uploaded a patch that adds tests for these letters. Also relocated them to a separate category under Greek Coptic letters.

@iamdmitrymayorov
5 months ago

Minor comment fix for previous patch

#7 @iamdmitrymayorov
5 months ago

Updated the patch that fixes a comment.

#8 @SergeyBiryukov
5 months ago

It looks like the ticket is about the Greek letter iota with dialytika and tonos: https://en.wiktionary.org/wiki/ΐ

44793.4.diff is an attempt to cover other similar symbols for consistency, including letter upsilon and standalone dialytika and tonos.

@dyrer, @ifrountas, @kosvrouvas, could you take a look at these changes to see if they are valid and remove_accents() should indeed handle these letters? Are there any other symbols that should be added?

Last edited 5 months ago by SergeyBiryukov (previous) (diff)

#10 @pento
3 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#11 @pento
5 weeks ago

  • Milestone changed from 5.0.1 to 5.0.2

#12 @pento
5 weeks ago

  • Milestone changed from 5.0.2 to 5.0.3

#13 @audrasjb
3 weeks ago

  • Keywords needs-testing added

Hi,

This ticket is triaged in milestone 5.0.3. Now it will needs commit and backport to the related branch. Adding dev-feedback needs-testing keywords to see if it can land in 5.0.3 at the very beginning of January.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 weeks ago

#15 @SergeyBiryukov
2 weeks ago

  • Milestone changed from 5.0.3 to 5.1
Note: See TracTickets for help on using tickets.