Creating subsite with un-trimmed space results in "Missing or invalid site address."

[aubreypwd]

When adding a site:

​http://aubrey.pw/d/2018/t96dsz13Kd.png

If the Site Address contains a space at the end (which is easily noticeable) it can result in "Missing or invalid site address.":

​http://aubrey.pw/d/2018/b9zBWfACwV.png

We can improve this by sanitizing/trimming whitespace from the input.

[dharmin16]

Add domain into trim function to trim spaces if added by mistake.

[jeremyfelt]

Good catch, it makes sense to trim this before validation.

@dharmin16 44808.patch​ looks like a good start, however the trim() should happen before validation rather than as a part of it. In the current form, the path is still saved with a space (e.g. /path-name /) in the database. This may mean using another variable to store $blog['domain'] during validation.

[dharmin16]

Trim domain name variable before validation

[dharmin16]

Hi @jeremyfelt,

As per your advice, I've added changes. I've named the temporary variable as $raw_domain. If it's confusing, please share your suggestions.

Thanks

[SergeyBiryukov]

In 45804:

Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation.

Props dharmin16, jeremyfelt, aubreypwd.
Fixes #44808.