Return a more accurate error message when user cannot perform the requested action

[desrosj]

When a user attempts to export or erase personal data, the export_others_personal_data and erase_others_personal_data & delete_users capabilities (respectively) are checked for the current user.

If these checks fail, Invalid Request. is returned as an error message. A more accurate error message should be returned that indicates the user does not have the required permission to perform the requested action.

[jplojohn]

I have added a patch file which provides more useful error descriptions for the user.

This is my first time contributing - I'm fairly sure this is correct in both code and procedure, but I may have misread the handbook!

[mmuhsin]

I just submitted a patch. Instead of 'Invalid Request.', I changed the message to read 'Sorry, you do not have permission to perform this task.'.

[garrett-eclipse]

Thanks @jplojohn and @mmuhsin for providing patches.

After reviewing the verbiage I would like to suggest the following to match better with existing conventions for these types of messages.

For both permission checks I'd suggest a single consistent string;
Sorry, you are not allowed to perform this action.

If you're able to refresh the patch that's always appreciated.

[mmuhsin]

Updated error message with a consistent string.

[mmuhsin]

Thanks for the feedback @garrett-eclipse!

I have uploaded a new patch with the string you suggested for both the error messages.

[garrett-eclipse]

Thanks @mmuhsin I appreciate the quick update. This applies cleanly and looks good. Marking for commit in 5.2

[SergeyBiryukov]

In 44777:

Privacy: Return a more accurate error message when the user cannot perform the requested action.

Props mmuhsin, jplojohn, garrett-eclipse, desrosj.
Fixes #44833.