Self_Link Should Have Echo Option

[dshanske]

There is no get_self_link, so either one should be created or there should be an echo=true argument to address

[stevenkword]

Makes sense to me.

[jojotjebaby]

I just attached my patch. I went with the option to add the $echo = true option to the function.

This is my first contribution so some feedback would be welcome :)

[mobeen-abdullah]

First patch as a new contributor :)

[dshanske]

@mobeen-abdullah Yours is not a diff.

@jojotjebaby Yours is implemented correctly except for not noting the new variable is since 4.9.9 or such...

But, in thinking about this after my initial comment, self_link is useful beyond RSS, which means adding get_self_link without the esc_url makes sense, as only in the original intent of exporting for RSS feeds should you need to escape, and adding two variables to change whether it escapes or not doesn't make sense, so the get function is the better move.

So, self_link would just call get_self_link and echo it with esc_url.

[jojotjebaby]

@dshanske , ok I will implement it with the new function and add the patch on here.

[jojotjebaby]

Changed the patch to add a new function get_self_link that is called and echoed by self_link

[audrasjb]

Hi,

5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. It doesn't appear that ticket can be handled in the next couple of weeks (it will both needs a refresh and a formal review). Let's address it in 5.1 which is coming in February. Feel free to change/ask to change the milestone if you think the issue can be quickly resolved.

[desrosj]

This ticket has not received any attention during the 5.2 cycle. With beta 1 tomorrow, going to punt this to 5.3.

[donmhico]

Refresh the patch.

[dshanske]

I think this can get into 5.3 now, hopefully.

[audrasjb]

Proposal: some enhancements to inline docs

[pento]

In 45772:

Feeds: Introduce the get_self_link() function.

Corresponds to the self_link() template function.

This matches other feed template functions, using one function to get the value, and a different function to echo it.

Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
Fixes #44838.