Opened 6 years ago
Closed 5 years ago
#44838 closed enhancement (fixed)
Self_Link Should Have Echo Option
Reported by: | dshanske | Owned by: | pento |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Feeds | Keywords: | good-first-bug has-patch |
Focuses: | Cc: |
Description
There is no get_self_link, so either one should be created or there should be an echo=true argument to address
Attachments (5)
Change History (25)
This ticket was mentioned in Slack in #core by jojotjebaby. View the logs.
6 years ago
#4
@
6 years ago
- Version set to trunk
I just attached my patch. I went with the option to add the $echo = true option to the function.
This is my first contribution so some feedback would be welcome :)
This ticket was mentioned in Slack in #core by jojotjebaby. View the logs.
6 years ago
#6
follow-up:
↓ 7
@
6 years ago
@mobeen-abdullah Yours is not a diff.
@jojotjebaby Yours is implemented correctly except for not noting the new variable is since 4.9.9 or such...
But, in thinking about this after my initial comment, self_link is useful beyond RSS, which means adding get_self_link without the esc_url makes sense, as only in the original intent of exporting for RSS feeds should you need to escape, and adding two variables to change whether it escapes or not doesn't make sense, so the get function is the better move.
So, self_link would just call get_self_link and echo it with esc_url.
#7
in reply to:
↑ 6
@
6 years ago
@dshanske , ok I will implement it with the new function and add the patch on here.
@
6 years ago
Changed the patch to add a new function get_self_link that is called and echoed by self_link
#14
@
6 years ago
- Keywords needs-refresh added
- Milestone changed from 5.0.3 to 5.1
Hi,
5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. It doesn't appear that ticket can be handled in the next couple of weeks (it will both needs a refresh and a formal review). Let's address it in 5.1 which is coming in February. Feel free to change/ask to change the milestone if you think the issue can be quickly resolved.
#16
@
6 years ago
- Milestone changed from 5.2 to 5.3
This ticket has not received any attention during the 5.2 cycle. With beta 1 tomorrow, going to punt this to 5.3.
Makes sense to me.