WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 6 months ago

#44871 closed enhancement (fixed)

Always provide Privacy Policy guide

Reported by: garrett-eclipse Owned by: idea15
Milestone: 5.1 Priority: normal
Severity: minor Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch commit
Focuses: administration Cc:

Description

Hello,

While setting up a new site's Privacy Policy I went to find the guide and found it's not available until you've selected a Privacy Policy page.

It would be nice to always provide the guide so it can be used in creating the page rather than having to create the page and then come back to find the guide.

Cheers

Attachments (5)

Screen Shot 2018-08-30 at 11.37.18 AM.png (100.0 KB) - added by garrett-eclipse 11 months ago.
Before selecting page for Privacy Policy there's no reference to the Guide.
Screen Shot 2018-08-30 at 11.37.31 AM.png (119.9 KB) - added by garrett-eclipse 11 months ago.
The guide link only becomes available once a Privacy Policy is selected.
44871.patch (386 bytes) - added by mukesh27 11 months ago.
Try this patch to show privacy policy guide without selecting privacy policy page .
44871.2.diff (1.1 KB) - added by birgire 11 months ago.
Screen Shot 2019-01-05 at 12.20.47 AM.png (276.9 KB) - added by garrett-eclipse 6 months ago.
Successful test illustrating display of guide link/paragraph without Privacy Policy being set

Download all attachments as: .zip

Change History (18)

@garrett-eclipse
11 months ago

Before selecting page for Privacy Policy there's no reference to the Guide.

@garrett-eclipse
11 months ago

The guide link only becomes available once a Privacy Policy is selected.

#1 @mukesh27
11 months ago

  • Focuses administration added
  • Keywords has-screenshots added
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement

#2 @mukesh27
11 months ago

@garrett-eclipse As per core WP coding privacy policy guide content will show when anyone select privacy policy page drop down and save that page as privacy policy page then it will show guide content to know how and what content will show in privacy policy page.

@mukesh27
11 months ago

Try this patch to show privacy policy guide without selecting privacy policy page .

#3 @mukesh27
11 months ago

  • Keywords has-patch needs-testing added

@birgire
11 months ago

#4 @birgire
11 months ago

44871.patch looks good.

44871.2.diff further adjusts the indentation and moves the translators comment into the multi-line sprintf.

#5 @garrett-eclipse
11 months ago

Thanks @mukesh27 & @birgire , they both look good there.

#6 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 4.9.9

#7 @idea15
10 months ago

  • Owner set to idea15
  • Status changed from new to assigned

#8 @pento
9 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#9 @pento
7 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#10 @pento
7 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#11 @garrett-eclipse
6 months ago

  • Keywords commit added; needs-testing removed

Thanks again @mukesh27 & @birgire, I've applied and tested both patches successfully.
*Screen coming.

44871.2.diff can be committed.

@garrett-eclipse
6 months ago

Successful test illustrating display of guide link/paragraph without Privacy Policy being set

#12 @desrosj
6 months ago

  • Milestone changed from 5.0.3 to 5.1

Since this is a minor fix. let's address in 5.1.

#13 @pento
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44492:

Privacy: Always show the privacy policy guide.

Previously, the link to the privacy policy guide would only be displayed when a privacy policy page had been selected, but the guide is generally useful without that.

Props mukesh27, birgire.
Fixes #44871.

Note: See TracTickets for help on using tickets.