Make WordPress Core

Opened 22 months ago

Closed 12 months ago

Last modified 12 months ago

#44878 closed enhancement (fixed)

"Are you sure" messaging is inconsistent

Reported by: johnjamesjacoby Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: good-first-bug has-patch
Focuses: Cc:

Description (last modified by johnjamesjacoby)

A quick search through the WordPress codebase shows inconsistent "Are you sure" messaging.

  • Are you sure you'd like to
  • Are you sure you want to
  • Are you sure you wish to
  • Are you sure you have

In my opinion, these specific instances should be normalized to take some guesswork away from our volunteers who translate WordPress into other languages.

While admittedly a minor issue, language is extremely nuanced. The difference between a like, wish and want may actually matter in some instances, but it doesn't in the ways that WordPress is using them.

In addition, making these consistent would not unintentionally make WordPress sound robotic or unfriendly in any way. We'd just be applying a consistent word choice across a few similar strings in wp-admin.

Attachments (1)

44878.diff (1.5 KB) - added by Presskopp 21 months ago.

Download all attachments as: .zip

Change History (8)

#1 @johnjamesjacoby
22 months ago

  • Description modified (diff)

#2 @SergeyBiryukov
22 months ago

  • Component changed from I18N to Text Changes
  • Keywords i18n-change removed

#3 @SergeyBiryukov
22 months ago

  • Milestone changed from Awaiting Review to Future Release

21 months ago

#4 @Presskopp
21 months ago

  • Keywords has-patch added

Most of the time we are using Are you sure you want .. so I adjusted 1x you'd like and 2x Are you sure you wish. Are you sure you have .. has a different context and can be left untouched.
One question remains, what about the usage of Are you sure that .. (found 3x) vs the usage without that - found in these 2 phrases:

Are you sure you have the correct username and password? and

Are you sure it exists?

#5 @SergeyBiryukov
12 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 5.3

The wp-includes/script-loader.php change is already committed in [45434], let's get the other two changes in.

#6 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45597:

Text Changes: Use consistent question wording for plugin and theme deletion confirmations.

Props johnjamesjacoby, Presskopp.
Fixes #44878.

#7 @SergeyBiryukov
12 months ago

In 45598:

Text Changes: Use consistent question wording in database connection error messages.

Props Presskopp.
See #44878.

Note: See TracTickets for help on using tickets.