Opened 6 years ago
Closed 6 years ago
#44889 closed enhancement (fixed)
Hide child theme creation message when we use child theme
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-screenshots dev-feedback needs-patch needs-refresh |
Focuses: | administration | Cc: |
Description
When we open http://wordpress.com/wp-admin/theme-editor.php page first time system show attached popup message in which it tell us "If you need to tweak more than your theme’s CSS, you might want to try making a child theme." but if we use child theme then also it show same message to create child theme and it create some confusion for any user so we have to hide that child theme creation message when we use child theme.
Attachments (5)
Change History (21)
#2
@
6 years ago
- Component changed from Editor to Themes
- Keywords needs-patch added; has-patch dev-feedback removed
#8
@
6 years ago
- Keywords needs-patch needs-refresh added; has-patch removed
- Milestone changed from 5.0.3 to 5.1
@mukesh27 I think 44889.2.patch
is missing some words on the first part of the translatable string.
Moving this ticket to 5.1 since 5.0.3 is going to be released very soon.
#9
@
6 years ago
@audrasjb You mean i needs to update text for child theme? As string translation is working fine for below statement.
_e( 'You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break.' );
#10
@
6 years ago
Sorry, that wasn't clear enough.
Is there a reason to remove "your site"? The correct sentence should be:
_e( 'You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site.' );
For reference, the current text is:
You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site and your changes may be lost in future updates. If you need to tweak more than your theme’s CSS, you might want to try <a href="%s">making a child theme</a>.
#11
follow-up:
↓ 12
@
6 years ago
Hi @audrasjb
When we use any child theme then also system show below message that tell user to use child theme instead of do changes in parent theme.
You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site and your changes may be lost in future updates. If you need to tweak more than your theme’s CSS, you might want to try <a href="%s">making a child theme</a>.
In 44889.2.patch
patch i just remove child theme reference if you have any proper text for child theme then please suggest so i can update patch for this ticket or i can update patch with below description.
You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site.
#12
in reply to:
↑ 11
@
6 years ago
Replying to mukesh27:
In
44889.2.patch
patch i just remove child theme reference if you have any proper text for child theme then please suggest so i can update patch for this ticket or i can update patch with below description.
You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site.
Then, why did you also remove "Your site"?
#14
@
6 years ago
- Milestone changed from 5.1 to 5.2
Instead of having two different but related strings, this string could be split up so that this prints for all themes:
You appear to be making direct edits to your theme in the WordPress dashboard. We recommend that you don’t! Editing your theme directly could break your site and your changes may be lost in future updates.
Additionally, this prints for themes that aren't child themes:
If you need to tweak more than your theme’s CSS, you might want to try <a href="%s">making a child theme</a>.
Updated Patch