WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#44919 closed defect (bug) (fixed)

Tooltip for the 'edit' button in the Classic Editor has unnecessary sufix

Reported by: adminrv's profile adminrv Owned by: desrosj's profile desrosj
Milestone: 5.0.3 Priority: normal
Severity: minor Version: 4.9.8
Component: Editor Keywords: has-patch has-screenshots
Focuses: Cc:

Description

Ich bin dabei in „WordPress Core“ Übersetzungen (Englisch – deutsch) durchzuführen. Ich kann den „source text“ für das Beispiel im Anhang nicht finden.

Vermutlich hat WordPress hier einen Softwarefehler (Edit|button).

Bitte um Unterstützung.

Attachments (2)

Edit.png​ (35.1 KB) - added by adminrv 6 years ago.
44919.diff​ (1.0 KB) - added by dimadin 6 years ago.

Download all attachments as: .zip

Change History (12)

@adminrv
6 years ago

#1 @mukesh27
6 years ago

  • Component changed from General to I18N

#2 @swissspidy
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Summary changed from SOFTWARE FEHLER BEI WORDPRESS? to Edit link tooltip not translatable

Hi @adminrv and welcome to Trac!

The tooltip text you're looking for (Edit) is defined here: ​https://github.com/WordPress/wordpress-develop/blob/fd5ba80c5c3d9cf62348567073945e246285fbca/src/wp-includes/class-wp-editor.php#L1273

The screenshot you shared doesn't show a UI that's part of WordPress, so I'd suggest checking whatever plugin or theme you're using to see if they're somehow using the editor / the wpLink component in a wrong way.

Make sure that this still happens with the default editor and no plugins installed in the latest version of WordPress.

It works perfectly in WordPress trunk. Here are some screenshots:

https://cldup.com/ra_-y2M0B0.png

https://cldup.com/Zewcq9m5vI.png

Ps. fürs nächste Mal: wir sprechen hier in der Regel Englisch :-)

#3 @garrett-eclipse
6 years ago

#45086 was marked as a duplicate.

@dimadin
6 years ago

#4 @dimadin
6 years ago

  • Component changed from I18N to Editor
  • Keywords has-patch has-screenshots added
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from Edit link tooltip not translatable to Tooltip for the 'edit' button in the Classic Editor has unnecessary sufix

Link @swissspidy posted is for code in trunk and this is happening in 4.9 and 5.0 branches after 4.9.8.

For #42543, @SergeyBiryukov committed [42523] for trunk. However, when @azaozz committed [43472] in 4.9 branch, he only merged changes to TinyMCE plugins, not to _WP_Editors::get_translation(), string there is still from [30839].

This is reproducible in both 4.9.8 and 5.0-RC2, with or without translation. Attachment attachment:44919.diff​ should go in both 4.9 and 5.0 branches.

https://cldup.com/Bk4Kxo7IxB-1200x1200.jpeg

#5 @swissspidy
6 years ago

  • Milestone set to 5.0.1
  • Severity changed from normal to minor

@dimadin Thanks for investigating & reopening this! I can now confirm the issue.

#6 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @pento
6 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#8 @audrasjb
6 years ago

  • Keywords commit added

This ticket is triaged in milestone 5.0.3 as 44919.diff looks fine. It will needs commit and backport to the related branch.

#9 @desrosj
6 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from reopened to closed

In 44401:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE.

In [42523], trunk was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in class-wp-editor.php was missed. This fixes the Edit string so not display as Edit|button in the 5.0 branch.

Props dimadin.

See #42543, #44134.
Fixes #44919.

#10 @desrosj
6 years ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.