Tooltip for the 'edit' button in the Classic Editor has unnecessary sufix

[adminrv]

Ich bin dabei in „WordPress Core“ Übersetzungen (Englisch – deutsch) durchzuführen. Ich kann den „source text“ für das Beispiel im Anhang nicht finden.

Vermutlich hat WordPress hier einen Softwarefehler (Edit|button).

Bitte um Unterstützung.

[swissspidy]

Hi @adminrv and welcome to Trac!

The tooltip text you're looking for (Edit) is defined here: ​https://github.com/WordPress/wordpress-develop/blob/fd5ba80c5c3d9cf62348567073945e246285fbca/src/wp-includes/class-wp-editor.php#L1273

The screenshot you shared doesn't show a UI that's part of WordPress, so I'd suggest checking whatever plugin or theme you're using to see if they're somehow using the editor / the wpLink component in a wrong way.

Make sure that this still happens with the default editor and no plugins installed in the latest version of WordPress.

It works perfectly in WordPress trunk. Here are some screenshots:

Ps. fürs nächste Mal: wir sprechen hier in der Regel Englisch :-)

[garrett-eclipse]

#45086 was marked as a duplicate.

[dimadin]

Link @swissspidy posted is for code in trunk and this is happening in 4.9 and 5.0 branches after 4.9.8.

For #42543, @SergeyBiryukov committed [42523] for trunk. However, when @azaozz committed [43472] in 4.9 branch, he only merged changes to TinyMCE plugins, not to _WP_Editors::get_translation(), string there is still from [30839].

This is reproducible in both 4.9.8 and 5.0-RC2, with or without translation. Attachment attachment:44919.diff​ should go in both 4.9 and 5.0 branches.

[swissspidy]

@dimadin Thanks for investigating & reopening this! I can now confirm the issue.

[audrasjb]

This ticket is triaged in milestone 5.0.3 as 44919.diff looks fine. It will needs commit and backport to the related branch.

[desrosj]

In 44401:

Editor: Use explicit context instead of a trailing space for Edit string in TinyMCE.

In [42523], trunk was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in class-wp-editor.php was missed. This fixes the Edit string so not display as Edit|button in the 5.0 branch.

Props dimadin.

See #42543, #44134.
Fixes #44919.