Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#44920 closed enhancement (fixed)

Twenty Seventeen: remove default_text_color from doc and add doc for video in twentyseventeen_custom_header_setup function

Reported by: mukesh27 Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: docs Cc:


$default_text_color is not used but it is mentioned in the documentation and $video is used but it is not mentioned in the documentation of the twentyseventeen_custom_header_setup() function.

Attachments (1)

44920.patch (1.0 KB) - added by mukesh27 3 years ago.

Download all attachments as: .zip

Change History (7)

3 years ago

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.

3 years ago

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.9.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @pento
3 years ago

  • Milestone changed from 4.9.9 to 5.0.1

#4 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#5 @laurelfulford
3 years ago

  • Milestone changed from 5.0.2 to 5.1

#6 @pento
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44462:

Docs: Correct the parameters passed to the twentyseventeen_custom_header_args filter.

The documented $default_text_color parameter isn't passed, and the $video parameter is passed, but not documented.

Props mukesh27.
Fixes #44920.

Note: See TracTickets for help on using tickets.