Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#44920 closed enhancement (fixed)

Twenty Seventeen: remove default_text_color from doc and add doc for video in twentyseventeen_custom_header_setup function

Reported by: mukesh27 Owned by: SergeyBiryukov
Priority: normal Milestone: 5.1
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

$default_text_color is not used but it is mentioned in the documentation and $video is used but it is not mentioned in the documentation of the twentyseventeen_custom_header_setup() function.

Attachments (1)

44920.patch​ (1.0 KB ) - added by mukesh27 8 years ago.

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.


8 years ago

#2 @SergeyBiryukov
8 years ago

  • Milestone Awaiting Review → 4.9.9
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#3 @pento
8 years ago

  • Milestone 4.9.9 → 5.0.1

#4 @pento
8 years ago

  • Milestone 5.0.1 → 5.0.2

#5 @laurelfulford
8 years ago

  • Milestone 5.0.2 → 5.1

#6 @pento
8 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 44462:

Docs: Correct the parameters passed to the twentyseventeen_custom_header_args filter.

The documented $default_text_color parameter isn't passed, and the $video parameter is passed, but not documented.

Props mukesh27.
Fixes #44920.

Note: See TracTickets for help on using tickets.