Unnecessary is_null() call in get_avatar_data()

[JPry]

In the get_avatar_data() function, this check comes immediately after the pre_get_avatar_data filter:

<?php
        if ( isset( $args['url'] ) && ! is_null( $args['url'] ) ) {
                /** This filter is documented in wp-includes/link-template.php */
                return apply_filters( 'get_avatar_data', $args, $id_or_email );
        }

The ! is_null() portion of the condition is unnecessary, because isset() checks whether a variable is set and is not null (​http://php.net/manual/en/function.isset.php).

[mukesh27]

@JPry check attached image for difference between isset and is_null.

[JPry]

Replying to mukesh27:

@JPry check attached image for difference between isset and is_null.

@mukesh27 I'm not sure what you're trying to show. I'm aware of the difference in isset() and is_null(), which is why I opened this ticket.

[mukesh27]

if $args['url'] value is empty then isset is not working.

[JPry]

Replying to mukesh27:

if $args['url'] value is empty then isset is not working.

This is about the use of isset( $args['url'] ) $$ ! is_null( $args['url'] ). It doesn't check using empty(), and I don't think it should be using empty(). This is because of the filter that comes directly above this statement. Please refer to the source code inline to see for yourself.

[SergeyBiryukov]

Introduced in [31107].

[SergeyBiryukov]

In 44351:

Users: Remove unnecessary is_null() call in get_avatar_data().

The ! is_null() portion of the condition is unnecessary, because isset() checks whether a variable is set *and* is not null.

Props JPry.
Fixes #44927.