WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#44944 closed defect (bug) (duplicate)

Possibly incorrect use of "continue" in wp-includeds/pomo/plural-forms.php

Reported by: tobifjellner Owned by: SergeyBiryukov
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: php73
Focuses: Cc:

Description

It seems as if wp-includeds/pomo/plural-forms.php uses a "stray" continue in line 210. This causes a warning to appear on some sites:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in [REDACTED]/wp-includes/pomo/plural-forms.php on line 210

Initial report (in Swedish): @rdcsg in https://sv.wordpress.org/support/topic/konstigt-felmeddelande-dyker-upp-pa-sajten-sen-dagar-tillbaka/

Attachments (1)

44944.patch (1.0 KB) - added by ayeshrajans 2 years ago.
This is due to PHP 7.3 deprecating this approach. Attaching a patch for this one and one more use in phpunit utils.php.

Download all attachments as: .zip

Change History (4)

@ayeshrajans
2 years ago

This is due to PHP 7.3 deprecating this approach. Attaching a patch for this one and one more use in phpunit utils.php.

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @jorbin
2 years ago

  • Milestone 4.9.9 deleted
  • Resolution set to duplicate
  • Status changed from reviewing to closed

This is fixed in [43653] and was previously opened as #44543.

#3 @desrosj
2 years ago

  • Keywords php73 added
Note: See TracTickets for help on using tickets.