WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 weeks ago

Last modified 4 weeks ago

#44952 closed defect (bug) (fixed)

Export and Erase personal data statuses missing label_count

Reported by: eArtboard Owned by: desrosj
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch has-screenshots
Focuses: ui, administration Cc:

Description

All registered statuses for Export and Erase personal data pages are missing the label_count parameter.

Attachments (5)

user.php (49.2 KB) - added by eArtboard 5 months ago.
post.php (215.2 KB) - added by eArtboard 5 months ago.
44952.diff (3.4 KB) - added by pratikkry 6 weeks ago.
converted @eArtboard patch into proper diff format
Screen Shot 2019-01-12 at 2.14.01 AM.png (66.0 KB) - added by garrett-eclipse 6 weeks ago.
Working counts #1
Screen Shot 2019-01-12 at 2.14.28 AM.png (67.3 KB) - added by garrett-eclipse 6 weeks ago.
Working counts test #2

Download all attachments as: .zip

Change History (22)

#1 @SergeyBiryukov
5 months ago

  • Component changed from Administration to Privacy
  • Focuses administration added

#2 @birgire
5 months ago

  • Keywords needs-patch added
  • Version changed from 4.9.8 to 4.9.6

Thanks for the ticket @eArtboard

The status labels are displayed above the privacy requests tables, so this seems to be needed.

This seems to be missing in create_initial_post_types():

https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-includes/post.php#L284

for request-completed, request-confirmed, request-failed and request-pending.

The WP_Privacy_Requests_Table::get_views() needs to adjusted as well to support this.

@eArtboard Have you considered writing a patch?

@eArtboard
5 months ago

@eArtboard
5 months ago

#3 @eArtboard
5 months ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

This is my first attempt to resolve a ticket. I have uploaded the related files with the changes.

#4 @birgire
5 months ago

Thanks @eArtboard congratulation with your first ticket patch

The patch should contain the file difference (diff), not the whole file.

Hope this helps:

https://make.wordpress.org/core/handbook/contribute/
https://make.wordpress.org/core/handbook/tutorials/working-with-patches/

Last edited 5 months ago by birgire (previous) (diff)

#5 @garrett-eclipse
5 months ago

  • Keywords needs-patch needs-refresh added; has-patch removed

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 months ago

#7 @desrosj
3 months ago

  • Keywords has-patch added; 2nd-opinion needs-patch removed
  • Milestone changed from Awaiting Review to 5.1

@eArtboard Are you able to create a proper patch for these changes? If you want to and are still having issues after reading through the links @birgire provided, you are welcome to ping me on Slack.

#8 @eArtboard
3 months ago

I am very busy this period. I will take a look how can I create a proper patch when I have some free time. Or maybe someone else want to create the patch.

@pratikkry
6 weeks ago

converted @eArtboard patch into proper diff format

#9 @pratikkry
6 weeks ago

  • Keywords needs-testing added; needs-refresh removed

#10 @desrosj
6 weeks ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#11 @garrett-eclipse
6 weeks ago

  • Keywords has-screenshots added; needs-testing removed

Thanks @eArtboard & @pratikkry for working on this.

The patch applies cleaning and functions nicely for both Erasure and Export tables. Uploading screenshots.

@desrosj this looks good to commit.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


6 weeks ago

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


5 weeks ago

#14 @garrett-eclipse
5 weeks ago

  • Keywords commit added

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


5 weeks ago

#16 @desrosj
5 weeks ago

  • Keywords commit removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

This was fixed in [44668] (sorry for the typo).

#17 @ocean90
4 weeks ago

In 44708:

Privacy: Use label_count property of post status for request counts in the list table views.

See #44952.
Fixes #46112.

Note: See TracTickets for help on using tickets.