#44952 closed defect (bug) (fixed)
Export and Erase personal data statuses missing label_count
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 4.9.6 |
Component: | Privacy | Keywords: | has-patch has-screenshots |
Focuses: | ui, administration | Cc: |
Description
All registered statuses for Export and Erase personal data pages are missing the label_count parameter.
Attachments (5)
Change History (22)
#3
@
5 years ago
- Keywords has-patch 2nd-opinion added; needs-patch removed
This is my first attempt to resolve a ticket. I have uploaded the related files with the changes.
#4
@
5 years ago
Thanks @eArtboard congratulation with your first ticket patch
The patch should contain the file difference (diff), not the whole file.
Hope this helps:
https://make.wordpress.org/core/handbook/contribute/
https://make.wordpress.org/core/handbook/tutorials/working-with-patches/
This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.
5 years ago
#7
@
5 years ago
- Keywords has-patch added; 2nd-opinion needs-patch removed
- Milestone changed from Awaiting Review to 5.1
@eArtboard Are you able to create a proper patch for these changes? If you want to and are still having issues after reading through the links @birgire provided, you are welcome to ping me on Slack.
#8
@
5 years ago
I am very busy this period. I will take a look how can I create a proper patch when I have some free time. Or maybe someone else want to create the patch.
#11
@
5 years ago
- Keywords has-screenshots added; needs-testing removed
Thanks @eArtboard & @pratikkry for working on this.
The patch applies cleaning and functions nicely for both Erasure and Export tables. Uploading screenshots.
@desrosj this looks good to commit.
Thanks for the ticket @eArtboard
The status labels are displayed above the privacy requests tables, so this seems to be needed.
This seems to be missing in
create_initial_post_types()
:https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-includes/post.php#L284
for
request-completed
,request-confirmed
,request-failed
andrequest-pending
.The
WP_Privacy_Requests_Table::get_views()
needs to adjusted as well to support this.@eArtboard Have you considered writing a patch?