Export and Erase personal data statuses missing label_count

[eArtboard]

All registered statuses for Export and Erase personal data pages are missing the label_count parameter.

[birgire]

Thanks for the ticket @eArtboard

The status labels are displayed above the privacy requests tables, so this seems to be needed.

This seems to be missing in create_initial_post_types():

https://core.trac.wordpress.org/browser/tags/4.9.8/src/wp-includes/post.php#L284

for request-completed, request-confirmed, request-failed and request-pending.

The WP_Privacy_Requests_Table::get_views() needs to adjusted as well to support this.

@eArtboard Have you considered writing a patch?

[eArtboard]

This is my first attempt to resolve a ticket. I have uploaded the related files with the changes.

[birgire]

Thanks @eArtboard congratulation with your first ticket patch

The patch should contain the file difference (diff), not the whole file.

Hope this helps:

​https://make.wordpress.org/core/handbook/contribute/
​https://make.wordpress.org/core/handbook/tutorials/working-with-patches/

[desrosj]

@eArtboard Are you able to create a proper patch for these changes? If you want to and are still having issues after reading through the links @birgire provided, you are welcome to ping me on Slack.

[eArtboard]

I am very busy this period. I will take a look how can I create a proper patch when I have some free time. Or maybe someone else want to create the patch.

[pratikkry]

converted @eArtboard patch into proper diff format

[garrett-eclipse]

Working counts #1

[garrett-eclipse]

Working counts test #2

[garrett-eclipse]

Thanks @eArtboard & @pratikkry for working on this.

The patch applies cleaning and functions nicely for both Erasure and Export tables. Uploading screenshots.

@desrosj this looks good to commit.

[desrosj]

This was fixed in [44668] (sorry for the typo).

[ocean90]

In 44708:

Privacy: Use label_count property of post status for request counts in the list table views.

See #44952.
Fixes #46112.