Context Navigation

← Previous Change
Ticket History
Next Change →

Changes between Initial Version and Version 1 of Ticket #44965

Timestamp:

09/19/2018 09:03:04 PM (8 years ago)

Author:

SergeyBiryukov

Comment:

What was the reasoning for unsetting that $_GET var?

error is one of the public query vars, and the further code checks if any of those vars is set via $_POST or $_GET , so it seems the reason is to make sure $this->query_vars['error'] is not set when there's no error.

There might be a better way to do that though, something like 44965.patch .

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #44965
- Property Component General → Query
- Property Keywords has-patch needs-unit-tests added

Ticket #44965 – Description

initial	v1
23	23	What was the reasoning for unsetting that $_GET var?
24	24
25		I see that they were added originally in ~~https://core.trac.wordpress.org/changeset/1570~~ (14 years ago), however is that still a valid reason?
	25	I see that they were added originally in [1570] (14 years ago), however is that still a valid reason?

Make WordPress Core

Context Navigation

Changes between Initial Version and Version 1 of Ticket #44965

Legend:

Ticket #44965

Ticket #44965 – Description