WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44965


Ignore:
Timestamp:
09/19/2018 09:03:04 PM (3 years ago)
Author:
SergeyBiryukov
Comment:

What was the reasoning for unsetting that $_GET var?

error is one of the public query vars, and the further code checks if any of those vars is set via $_POST or $_GET, so it seems the reason is to make sure $this->query_vars['error'] is not set when there's no error.

There might be a better way to do that though, something like 44965.patch.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44965

    • Property Keywords has-patch needs-unit-tests added
    • Property Component changed from General to Query
  • Ticket #44965 – Description

    initial v1  
    2323What was the reasoning for unsetting that $_GET var?
    2424
    25 I see that they were added originally in https://core.trac.wordpress.org/changeset/1570 (14 years ago), however is that still a valid reason?
     25I see that they were added originally in [1570] (14 years ago), however is that still a valid reason?