WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#44998 closed defect (bug) (fixed)

Make translator comment consistent between instance

Reported by: garrett-eclipse Owned by: pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: coding-standards Cc:

Attachments (1)

44998.diff (1.8 KB) - added by ramonopoly 3 years ago.
Adding a patch to make the translator's comments consistent

Download all attachments as: .zip

Change History (12)

#1 @garrett-eclipse
3 years ago

  • Keywords i18n-change good-first-bug added

#2 in reply to: ↑ description @SergeyBiryukov
3 years ago

  • Component changed from General to I18N
  • Milestone changed from Awaiting Review to 5.0

Replying to garrett-eclipse:

As well as the difference above it should be noted that the translator comments are missing completely from the 'Email, URL and Comment' strings found here;
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-includes/pluggable.php?marks=1497#L1498

That's already fixed in [42827].

The other issue (comment author vs. comment author name) still stands though, they should indeed be consistent.

#3 @SergeyBiryukov
3 years ago

  • Keywords i18n-change removed

#4 @garrett-eclipse
3 years ago

  • Owner set to garrett-eclipse
  • Status changed from new to accepted

Nice thanks @SergeyBiryukov makes this a much smaller task

#5 @jrf
3 years ago

FYI: The missing translators comments are being addressed in issue #44360.

@ramonopoly
3 years ago

Adding a patch to make the translator's comments consistent

#6 @ramonopoly
3 years ago

  • Keywords has-patch added
  • Resolution set to invalid
  • Status changed from accepted to closed

#7 @pento
3 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#8 @pento
3 years ago

  • Owner changed from garrett-eclipse to pento
  • Status changed from reopened to assigned

#9 @pento
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43668:

i18n: Improve consistency of translator comments.

Props ramonopoly.
Fixes #44998.

#10 @johnbillion
3 years ago

  • Keywords good-first-bug removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[43668] should be merged into 5.0

#11 @pento
3 years ago

  • Keywords has-patch removed
  • Milestone changed from 5.0 to 5.1
  • Resolution set to fixed
  • Status changed from reopened to closed

Let's just leave it in 5.1.

Note: See TracTickets for help on using tickets.