Opened 6 years ago
Closed 6 years ago
#44998 closed defect (bug) (fixed)
Make translator comment consistent between instance
Reported by: | garrett-eclipse | Owned by: | pento |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | |
Focuses: | coding-standards | Cc: |
Description
Hello,
This is minor, but the translator comments should be consistent.
I found this case here - https://translate.wordpress.org/projects/wp/dev/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=5143992&filters%5Btranslation_id%5D=52318953
Which has two instances;
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-includes/pluggable.php?marks=1497#L1497
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-includes/pluggable.php?marks=1657#L1657
As well as the difference above it should be noted that the translator comments are missing completely from the 'Email, URL and Comment' strings found here;
https://core.trac.wordpress.org/browser/branches/4.9/src/wp-includes/pluggable.php?marks=1497#L1498
Attachments (1)
Change History (12)
#2
in reply to:
↑ description
@
6 years ago
- Component changed from General to I18N
- Milestone changed from Awaiting Review to 5.0
#4
@
6 years ago
- Owner set to garrett-eclipse
- Status changed from new to accepted
Nice thanks @SergeyBiryukov makes this a much smaller task
#6
@
6 years ago
- Keywords has-patch added
- Resolution set to invalid
- Status changed from accepted to closed
#8
@
6 years ago
- Owner changed from garrett-eclipse to pento
- Status changed from reopened to assigned
Replying to garrett-eclipse:
That's already fixed in [42827].
The other issue (
comment author
vs.comment author name
) still stands though, they should indeed be consistent.