Make WordPress Core

Opened 6 years ago

Closed 2 months ago

Last modified 8 weeks ago

#45006 closed enhancement (fixed)

On Bulk Actions either suppress until checkboxes selected or provide feedback that the action had no items to act on

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: joedolson's profile joedolson
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: administration Cc:

Description

Hello,

It seems to be the convention in core to simply have no action response when you attempt to execute the Bulk Actions and have no items selected.

In #44081 the 44081.3.2.diff provided a concept for the error;

<?php
if ( empty( $request_ids ) ) {
    add_settings_error(
        'bulk_action',
        'bulk_action',
        __( 'There were no requests to act on.' )
    );
    return;
}

Or it may be a better queue to simply disable the button when no checkboxes are checked. This avoids triggering the action in the first place.

Thanks

Change History (7)

#1 @SergeyBiryukov
6 years ago

  • Focuses coding-standards removed
  • Keywords ux-feedback added

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


5 years ago

#4 @nrqsnchz
5 years ago

  • Keywords ux-feedback removed

Or it may be a better queue to simply disable the button when no checkboxes are checked.

Reviewed during today's design triage in Slack (https://wordpress.slack.com/archives/C02S78ZAL/p1578333241024900).

We agree that disabling the button is a good approach. This is also a common pattern found elsewhere, so we expect most users to understand the interaction.

#5 @SergeyBiryukov
3 years ago

#54881 was marked as a duplicate.

#6 @joedolson
2 months ago

  • Owner set to joedolson
  • Resolution set to fixed
  • Status changed from new to closed

In 59134:

Quick/Bulk Edit: Add notice if no items selected.

Add an error notice if a user attempts to apply bulk edits with no items selected. Applies to post lists, comments, taxonomies, and plugins screens.

Props garrett-eclipse, nrqsnchz, sumitsingh, nihar007, royho, sabernhardt, oglekler, quadthemes, ankit-k-gupta, fnpen, ukdrahul, joedolson.
Fixes #45006, #58479.

#7 @desrosj
8 weeks ago

  • Milestone changed from Awaiting Review to 6.7
Note: See TracTickets for help on using tickets.