Make WordPress Core

Opened 8 years ago

Closed 2 years ago

Last modified 2 years ago

#45006 closed enhancement (fixed)

On Bulk Actions either suppress until checkboxes selected or provide feedback that the action had no items to act on

Reported by: garrett-eclipse Owned by: joedolson
Priority: normal Milestone: 6.7
Component: Administration Version:
Severity: normal Keywords:
Cc: Focuses: administration

Description

Hello,

It seems to be the convention in core to simply have no action response when you attempt to execute the Bulk Actions and have no items selected.

In #44081 the 44081.3.2.diff provided a concept for the error;

<?php
if ( empty( $request_ids ) ) {
    add_settings_error(
        'bulk_action',
        'bulk_action',
        __( 'There were no requests to act on.' )
    );
    return;
}

Or it may be a better queue to simply disable the button when no checkboxes are checked. This avoids triggering the action in the first place.

Thanks

Change History (7)

#1 @SergeyBiryukov
8 years ago

  • Focuses coding-standards removed
  • Keywords ux-feedback added

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.


7 years ago

#4 @nrqsnchz
7 years ago

  • Keywords ux-feedback removed

Or it may be a better queue to simply disable the button when no checkboxes are checked.

Reviewed during today's design triage in Slack (​https://wordpress.slack.com/archives/C02S78ZAL/p1578333241024900).

We agree that disabling the button is a good approach. This is also a common pattern found elsewhere, so we expect most users to understand the interaction.

#5 @SergeyBiryukov
5 years ago

#54881 was marked as a duplicate.

#6 @joedolson
2 years ago

  • Owner set to joedolson
  • Resolution → fixed
  • Status new → closed

In 59134:

Quick/Bulk Edit: Add notice if no items selected.

Add an error notice if a user attempts to apply bulk edits with no items selected. Applies to post lists, comments, taxonomies, and plugins screens.

Props garrett-eclipse, nrqsnchz, sumitsingh, nihar007, royho, sabernhardt, oglekler, quadthemes, ankit-k-gupta, fnpen, ukdrahul, joedolson.
Fixes #45006, #58479.

#7 @desrosj
2 years ago

  • Milestone Awaiting Review → 6.7
Note: See TracTickets for help on using tickets.