WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#45024 closed enhancement (fixed)

Space out mobile row actions

Reported by: jobthomas Owned by: jobthomas
Milestone: 5.1 Priority: normal
Severity: minor Version: 5.1
Component: Administration Keywords: has-patch has-screenshots
Focuses: ui Cc:
PR Number:

Description

On mobile, if there are multiple row actions expanding over more than 1 line, the actions on both lines are very cramped together making it easy to click the wrong item.

I'll submit a small patch spacing that out a bit better.

Attachments (14)

before.png (98.8 KB) - added by jobthomas 14 months ago.
after.png (100.3 KB) - added by jobthomas 14 months ago.
45024.diff (518 bytes) - added by jobthomas 14 months ago.
45024.1.diff (1.4 KB) - added by jobthomas 14 months ago.
diff45024.1.after.png (104.0 KB) - added by jobthomas 14 months ago.
diff45024.2.after.png (34.8 KB) - added by jobthomas 14 months ago.
45024.2.diff (1.4 KB) - added by jobthomas 14 months ago.
45024.3.diff (596 bytes) - added by jobthomas 14 months ago.
45024.4.diff (660 bytes) - added by jobthomas 14 months ago.
45024.5.diff (660 bytes) - added by jobthomas 14 months ago.
45024.6.diff (743 bytes) - added by jobthomas 14 months ago.
45024.7.diff (783 bytes) - added by jobthomas 14 months ago.
45024.8.diff (1.0 KB) - added by ryelle 14 months ago.
45024.9.diff (1.1 KB) - added by jobthomas 14 months ago.

Download all attachments as: .zip

Change History (26)

@jobthomas
14 months ago

@jobthomas
14 months ago

@jobthomas
14 months ago

#1 @joyously
14 months ago

Are you sure you didn't upload the same image twice?

#2 follow-up: @melchoyce
14 months ago

How about some more horizontal space in addition to the vertical space?

@joyously — check out the actions at the bottom (unapprove/reply/etc.). The bottom screenshot has more vertical space.

#3 in reply to: ↑ 2 @jobthomas
14 months ago

Replying to melchoyce:

How about some more horizontal space in addition to the vertical space?

@joyously — check out the actions at the bottom (unapprove/reply/etc.). The bottom screenshot has more vertical space.

Sounds good. Working on that.

@jobthomas
14 months ago

#4 @melchoyce
14 months ago

Hey @jobthomas, I think you may have had another patch applied when you made this one.

#5 @jobthomas
14 months ago

Small update coming - deleting .mobile makes that the plugins' row actions look more consistent as well (see screenshot below)

@jobthomas
14 months ago

@jobthomas
14 months ago

#6 @jobthomas
14 months ago

Fixed @melchoyce

#7 @melchoyce
14 months ago

Looking good. Two quick comments:

  1. What if we move the padding to the a, so the link touch-target is larger?
  2. Can we remove the right padding on the last item in the list?

#8 @jobthomas
14 months ago

Thanks for the input - see new patch

@jobthomas
14 months ago

@jobthomas
14 months ago

@jobthomas
14 months ago

@jobthomas
14 months ago

@ryelle
14 months ago

@jobthomas
14 months ago

#9 @jobthomas
14 months ago

Thanks @ryelle - I've added a small change to exclude plugins-php as that looked a bit odd.

#10 @melchoyce
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43670:

List Tables: Arrange action items into a grid with extra space.

On small screens, list table actions were cramped. This makes it easy to press the wrong action by mistake. The items are now arranged into a grid and given extra room to create a larger tap-target.

The plugins list table was excluded because it's current layout doesn't match the others, and we should add more space to this in a future commit.

Props jobthomas, ryelle.
Fixes #45024.

#11 @netweb
14 months ago

  • Milestone changed from Awaiting Review to 5.0

#12 @pento
14 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.