WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#45028 closed defect (bug) (fixed)

Comments bulk actions aren't displaying below the comments list

Reported by: jobthomas Owned by: melchoyce
Priority: normal Milestone: 5.1
Component: Comments Version:
Severity: normal Keywords: has-screenshots
Cc: Focuses: administration

Description

On mobile, there are no bulk actions on comments, contrary to pages and posts. This also results in a weird "item" overlap with the search box. See screenshots.

Attachments (4)

pages.png​ (64.4 KB ) - added by jobthomas 8 years ago.
comments.png​ (51.2 KB ) - added by jobthomas 8 years ago.
45028.diff​ (797 bytes ) - added by shaneeckert 8 years ago.
45028 Fix where extra items may be empty, which will prevent the table nav from displaying later.
45028.2.diff​ (1.3 KB ) - added by dd32 8 years ago.
Code formatting changes required to 45028.diff

Download all attachments as: .zip

Change History (17)

@jobthomas
8 years ago

@jobthomas
8 years ago

#1 @jobthomas
8 years ago

  • Component General → Administration
  • Focuses administration added

#2 @jobthomas
8 years ago

  • Summary On mobile, comments bulk actions aren't displaying → Comments bulk actions aren't displaying below the comments list

#3 @mukesh27
8 years ago

  • Component Administration → Comments
  • Keywords needs-patch ui-feedback has-screenshots dev-feedback added

@shaneeckert
8 years ago

45028 Fix where extra items may be empty, which will prevent the table nav from displaying later.

#4 @dd32
8 years ago

  • Keywords commit added

After going down the rabbit hole of what $extra_items is, 45028.diff​ looks good to me.

#5 @melchoyce
8 years ago

  • Owner set to melchoyce
  • Resolution → fixed
  • Status new → closed

In 43671:

List Table: Restore the List Table items property to allow Bulk Actions to be properly determined.

This fixes the display of Bulk Actions where there exists only a single page of results.

Props shaneeckert, jobthomas, dd32.
Fixes #45028.

@dd32
8 years ago

Code formatting changes required to 45028.diff

#6 @melchoyce
8 years ago

In 43672:

List Table: Fix formatting issue introduced in r43671.

Props dd32.
See #45028.

#7 @netweb
8 years ago

  • Milestone Awaiting Review → 5.0

#8 @johnbillion
8 years ago

  • Keywords needs-patch ui-feedback dev-feedback commit removed
  • Milestone 5.0 → 5.0.1
  • Resolution fixed
  • Status closed → reopened

#9 @pento
8 years ago

  • Milestone 5.0.1 → 5.0.2

#10 @pento
8 years ago

  • Milestone 5.0.2 → 5.0.3

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
8 years ago

#12 @desrosj
8 years ago

  • Keywords fixed-major added

#13 @desrosj
8 years ago

  • Keywords fixed-major removed
  • Milestone 5.0.3 → 5.1
  • Resolution → fixed
  • Status reopened → closed

Let's leave this in 5.1 as this is outside of the 5.0.3 scope.

Note: See TracTickets for help on using tickets.