Opened 6 years ago
Closed 6 years ago
#45032 closed enhancement (fixed)
Replace incorrect usage of `'who's` with `whose`
Reported by: | burhandodhy | Owned by: | netweb |
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Users | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Related to #45026 "pluggable.php" still have the who's
word
Attachments (2)
Change History (13)
#2
@
6 years ago
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to 5.0
The patch needs a refresh, the current 45032.patch removes the end-of-file new line, all PHP files should have a new blank line at the end of the file
#3
follow-up:
↓ 4
@
6 years ago
I just rechecked pluggable.php it has two newlines at the end of the file. I removed the extra end line in my patch. I can resubmit the patch without changing the endline.
#4
in reply to:
↑ 3
@
6 years ago
- Keywords commit added
Replying to AbdulWahab610:
I just rechecked pluggable.php it has two newlines at the end of the file. I removed the extra end line in my patch. I can resubmit the patch without changing the endline.
Ah, perfect, thanks @AbdulWahab610, the patch 45032.patch is fine as is then
#5
follow-up:
↓ 10
@
6 years ago
- Keywords commit removed
The current use appears to be correct in that it's a contraction of "who is" rather than possessive.
That said, it could use some editing. :)
How about: "If $id
matches the current user, there's nothing to do"
#7
@
6 years ago
- Component changed from General to Users
- Focuses docs added
- Summary changed from Related #45026 Replace incorrect usage of `'who's` with `whose` to Replace incorrect usage of `'who's` with `whose`
#10
in reply to:
↑ 5
@
6 years ago
- Keywords needs-refresh removed
Replying to jeremyfelt:
The current use appears to be correct in that it's a contraction of "who is" rather than possessive.
That said, it could use some editing. :)
How about: "If
$id
matches the current user, there's nothing to do"
Applied this suggestion.
Fixed