Opened 6 years ago
Last modified 6 years ago
#45052 reviewing defect (bug)
WP Oembed in multisite fail when the permalink structure is not default
Reported by: | imath | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Embeds | Keywords: | has-patch dev-feedback needs-refresh |
Focuses: | multisite | Cc: |
Description
This is a follow up of #40673
In case blogs are using pretty urls (which should be the most common case), when you try to embed a post from the main site into a sub site, the embedded URL is not interpreted and we keep that simple URL.
Thats because the main site is using a reserved blog prefix /blog
we need to remove before using get_sites()
. I've added a unit test to illustrate the bug.
Attachments (2)
Change History (13)
#1
@
6 years ago
- Milestone changed from Awaiting Review to 5.0.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#6
@
6 years ago
- Milestone changed from 5.0.3 to 5.1
Going to punt this to 5.1. It is outside of the scope for 5.0.3 (block editor bugs, regressions, and major bugs). If it ready and committed to trunk
before 5.0.3 beta, we can consider backporting it.
#7
@
6 years ago
- Milestone changed from 5.1 to 5.2
Looking at the related condition in options-permalink.php, it seems like there should be some extra checks before removing this?
This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
6 years ago
#11
@
6 years ago
- Milestone changed from 5.2 to Future Release
Per today's bugscrub, we're punting this as not enough time remains to get this into 5.2. Given the minimal movement during the 5.2 release cycle, I'm punting this to Future Release so that we consciously milestone this for a numbered release when we're ready to take it on.
Hi and thanks for the patch,
5.0.3 is going to be released soon. We are currently sorting the remaining tickets in the milestone.
The component maintainers for
Embeds
are @wonderboymusic @swissspidy and @azaozzDo you think this ticket can be handled in the next couple of weeks? If not, let's address this in 5.1 which is coming soon.