Opened 8 years ago
Last modified 4 months ago
#45052 reviewing defect (bug)
WP Oembed in multisite fail when the permalink structure is not default
| Reported by: | imath | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Embeds | Version: | |
| Severity: | normal | Keywords: | has-patch dev-feedback has-unit-tests |
| Cc: | Focuses: | multisite |
Description
This is a follow up of #40673
In case blogs are using pretty urls (which should be the most common case), when you try to embed a post from the main site into a sub site, the embedded URL is not interpreted and we keep that simple URL.
Thats because the main site is using a reserved blog prefix /blog we need to remove before using get_sites(). I've added a unit test to illustrate the bug.
Attachments (2)
Change History (14)
This ticket was mentioned in Slack in #core by desrosj. View the logs.
8 years ago
#6
@
8 years ago
- Milestone 5.0.3 → 5.1
Going to punt this to 5.1. It is outside of the scope for 5.0.3 (block editor bugs, regressions, and major bugs). If it ready and committed to trunk before 5.0.3 beta, we can consider backporting it.
#7
@
8 years ago
- Milestone 5.1 → 5.2
Looking at the related condition in options-permalink.php, it seems like there should be some extra checks before removing this?
This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.
7 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
7 years ago
#11
@
7 years ago
- Milestone 5.2 → Future Release
Per today's bugscrub, we're punting this as not enough time remains to get this into 5.2. Given the minimal movement during the 5.2 release cycle, I'm punting this to Future Release so that we consciously milestone this for a numbered release when we're ready to take it on.
@
7 years ago
Refresh. Also to mention that the original patch was applied directly on the function wp_filter_pre_oembed_resultthis has change from the current core state to get_oembed_response_data_for_url
This ticket was mentioned in PR #11926 on WordPress/wordpress-develop by @sainathpoojary.
4 months ago
#12
- Keywords has-unit-tests added; needs-refresh removed
Trac ticket: #45052
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hi and thanks for the patch,
5.0.3 is going to be released soon. We are currently sorting the remaining tickets in the milestone.
The component maintainers for
Embedsare @wonderboymusic @swissspidy and @azaozzDo you think this ticket can be handled in the next couple of weeks? If not, let's address this in 5.1 which is coming soon.