Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45063 closed task (blessed) (fixed)

Remove the "Try Gutenberg" callout

Reported by: pento's profile pento Owned by: pento's profile pento
Milestone: 4.9.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch fixed-major fixed-5.0
Focuses: Cc:

Description

The callout won't be needed in the 5.0 branch, and it can be removed from the 4.9 branch, as the Gutenberg plugin minimum version will be bumped to require 5.0, after it's released.

Attachments (2)

45063.patch (25.2 KB) - added by mukesh27 6 years ago.
Remove all occurrence of Gutenberg from core files.
45063.2.patch (24.1 KB) - added by mukesh27 6 years ago.
Updated patch as per Slack discussion with @pento.

Download all attachments as: .zip

Change History (14)

#1 @mukesh27
6 years ago

  • Keywords has-patch added; needs-patch removed

@pento so we have to remove all occurrence of Gutenberg from core files( php, css, js ).

i have remove all occurrence of Gutenberg from development version (4.9.9-alpha-43656). try attached patch.

@mukesh27
6 years ago

Remove all occurrence of Gutenberg from core files.

#2 @Luciano Croce
6 years ago

I totally agree with @pento :) Thank you for this ticket, and also for all the other implicit reasons ;) Besides, I think that it's time to integrate Gutenberg as soon as possible in the core.

Last edited 6 years ago by Luciano Croce (previous) (diff)

#3 @pento
6 years ago

  • Keywords needs-refresh added

Thank you for the patch, @mukesh27!

A couple of notes:

  • Would you mind doing it against the 5.0 branch? That's the primary focus, we'll worry about backporting to the 4.9 branch later.
  • You don't need to remove the reference in wp-admin/about.php, we're just removing the box from the Dashboard.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


6 years ago

@mukesh27
6 years ago

Updated patch as per Slack discussion with @pento.

#5 @mukesh27
6 years ago

  • Keywords needs-refresh removed

#6 @netweb
6 years ago

Related: #45073 Upgrading to 5.0 and handling the Gutenberg plugin

#7 @JoshuaWold
6 years ago

Agreed with removing the callout. In #45073 I'll be sharing a sketch shortly with a much smaller callout suggestion.

#8 @postphotos
6 years ago

In our (@joshuawold + I) discussion yesterday, after this callout is removed we'd suggest a much quieter callout that nudges folks to still try the new editor, especially as it helps with on the new paths to be proposed in #45073, as well as help inform users of the big changes across the board.

As each admin updates to 5.0, some might be ready (and excited) for Gutenberg. Some may be hesitant and need assistance. Some might still want to experiment on a per-post or per-post-type basis. While we'd wish everyone would test changes as core as this in a staging environment, that definitely isn't the case for every site and they might.

A proposed callout to replace the current one could say to Classic-default sites:

  • Try Gutenberg (a smaller version of what currently exists)
  • Learn more about why and how

And to Guten-default sites:

  • Learn more about why and how
  • Get classic back (if you need it)
  • "Beta" test by installing the Guten plugin

Should we break this out into a new issue, or is this the right place for this discussion?

#9 @pento
6 years ago

@postphotos: Let's keep new callout discussion to #45073 or a new issue, this one can just be for removing the old callout from 5.0 and 4.9 branches.

#10 @pento
6 years ago

In 43807:

Dashboard: Remove the Try Gutenberg callout.

Block or block not. There is no try.

Props mukesh27.
See #45063.

#11 @pento
6 years ago

  • Keywords fixed-major fixed-5.0 added

Fixed in the 5.0 branch, leaving this ticket open for backporting to the 4.9 branch later.

#12 @pento
6 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 44106:

Dashboard: Remove the Try Gutenberg callout.

Merge of [43807] from the 5.0 branch.

Props mukesh27.
Fixes #45063.

Note: See TracTickets for help on using tickets.