#45064 closed defect (bug) (fixed)
Fix grunt-sass in the 5.0 branch
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
Trying to build WordPress in a newly created checkout of the 5.0 branch fails as it tries to use very outdated node-sass
dependency. Error message when doing npm install
:
> node-sass@3.13.1 install [...]WordPress-5.0\node_modules\node-sass > node scripts/install.js Downloading binary from https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node Cannot download "https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node": HTTP error 404 Not Found
Change History (9)
This ticket was mentioned in Slack in #core-committers by azaozz. View the logs.
6 years ago
#4
@
6 years ago
- Owner set to jorbin
- Resolution set to fixed
- Status changed from new to closed
In 43684:
#9
@
6 years ago
Changeset [44320] Timestamp: 12/19/2018 12:33:59 AM (64 minutes ago) Author: jeremyfelt Message: Build: Update images following [43684]. grunt-contrib-imagemin was updated, which included some changes to image minification. Those changes are now applies. Merges [43785] from the 5.0 branch to trunk. Props netweb. See #45080.
Note: See
TracTickets for help on using
tickets.
Removing
npm-shrinkwrap.json
(as in trunk) and updatinggrunt-sass
to2.0.0
inpackage.json
fixes this problem (tested in fresh checkout on Win10).