#45064 closed defect (bug) (fixed)
Fix grunt-sass in the 5.0 branch
| Reported by: | azaozz | Owned by: | jorbin |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.0 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
Trying to build WordPress in a newly created checkout of the 5.0 branch fails as it tries to use very outdated node-sass dependency. Error message when doing npm install:
> node-sass@3.13.1 install [...]WordPress-5.0\node_modules\node-sass > node scripts/install.js Downloading binary from https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node Cannot download "https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node": HTTP error 404 Not Found
Change History (9)
This ticket was mentioned in Slack in #core-committers by azaozz. View the logs.
8 years ago
#9
@
8 years ago
Changeset [44320]
Timestamp: 12/19/2018 12:33:59 AM (64 minutes ago)
Author: jeremyfelt
Message:
Build: Update images following [43684].
grunt-contrib-imagemin was updated, which included some changes to image minification. Those changes are now applies.
Merges [43785] from the 5.0 branch to trunk.
Props netweb.
See #45080.
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Removing
npm-shrinkwrap.json(as in trunk) and updatinggrunt-sassto2.0.0inpackage.jsonfixes this problem (tested in fresh checkout on Win10).