WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 9 months ago

#45064 closed defect (bug) (fixed)

Fix grunt-sass in the 5.0 branch

Reported by: azaozz Owned by: jorbin
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

Trying to build WordPress in a newly created checkout of the 5.0 branch fails as it tries to use very outdated node-sass dependency. Error message when doing npm install:

> node-sass@3.13.1 install [...]WordPress-5.0\node_modules\node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v3.13.1/win32-x64-57_binding.node":

HTTP error 404 Not Found

Change History (9)

#1 @azaozz
12 months ago

Removing npm-shrinkwrap.json (as in trunk) and updating grunt-sass to 2.0.0 in package.json fixes this problem (tested in fresh checkout on Win10).

This ticket was mentioned in Slack in #core-committers by azaozz. View the logs.


12 months ago

#3 @jorbin
12 months ago

In 43683:

Build/Test: Remove npm-shrinkwrap.json

Shrinkwraping is done to keep dependencies the same. Historically, WordPress Core has done it after a release. As the 5.0 branch was created from the 4.9.8 tag which was created from the 4.9 branch, it included it. The 5.0 branch will have some dependency updates so this shrinkwrap is not needed here.

See #45064.

#4 @jorbin
12 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 43684:

Build/Test: Update dependencies for 5.0

Updates package dependencies to more modern versions, also adds .nvmrc and package-lock.json as followups to [43683] and [43571].

See #44600.
Fixes #45064.

#5 @jorbin
12 months ago

In 43685:

Build/Test: Use same grunt-qunit as trunk for 5.0

See [43684].
See #45064.

#6 @jorbin
12 months ago

In 43686:

Build/Test Tools: Revert grunt-contrib-uglify update

Follow up to [43684].
See #45064.

#7 @SergeyBiryukov
12 months ago

In 43721:

Build: Bump the version of node used on Travis to match package.json for 5.0.

See [43684].
See #45064.

#8 @atimmer
10 months ago

In 43977:

Build/Test: Update dependencies for 5.0

Updates package dependencies to more modern versions, also adds .nvmrc and package-lock.json as followups to [43683] and [43571].

Merge notes: trunk already had an identical .nvmrc. package-lock.json exists in trunk, but has some changes based on the dependency updates.

Props jorbin.
Merges [43684], [43685] and [43686] to trunk.
See #44600.
Fixes #45064.

#9 @netweb
9 months ago

Changeset [44320]

Timestamp: 12/19/2018 12:33:59 AM (64 minutes ago) 
Author: jeremyfelt
Message:

    Build: Update images following [43684].

    grunt-contrib-imagemin was updated, which included some changes to image minification. Those changes are now applies.

    Merges [43785] from the 5.0 branch to trunk.

    Props netweb.
    See #45080.

Note: See TracTickets for help on using tickets.