Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45065, comment 21


Ignore:
Timestamp:
10/18/2018 10:57:06 AM (5 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45065, comment 21

    initial v1  
    33Before the changes `do_action( 'before_wp_tiny_mce', self::$mce_settings );` was firing before tinymce.js was loaded. Now it fires after.
    44
    5 Similarly tinymce.js was loaded after `tinyMCEPreInit` was defined, now it loads before. Both happen as tinymce.js is now always enqueued through script-loader, regardless of where it is used.
     5Similarly `tinyMCEPreInit` was defined before tinymce.js was loaded, now it's defined after. This is especially important as TinyMCE looks for `tinyMCEPreInit` to get some predefined settings, see https://github.com/tinymce/tinymce/blob/7dfd8102cadfb35e7304cacec7f122aa9e81b1ad/src/core/main/ts/api/EditorManager.ts#L195.
     6
     7Both happen as tinymce.js is now always enqueued through script-loader, regardless of where it is used.
    68
    79Both of these don't affect loading of TinyMCE in core, but may affect plugins. Since we are trying to be very careful not to break anything in the 5.0 branch, thinking that change should be reverted.