Opened 6 years ago
Closed 6 years ago
#45080 closed defect (bug) (fixed)
Update Autoprefixer
Reported by: | netweb | Owned by: | |
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Build/Test Tools | Keywords: | has-patch fixed-5.0 commit |
Focuses: | Cc: |
Description
Update Autoprefixer from 6.5.1
to 9.1.5
https://github.com/postcss/autoprefixer/compare/6.5.1...9.1.5
Autoprefixer was upgraded in the 5.0
branch from 6.5.1
to 9.1.5
in [43684] as part of #45064.
As a follow up running grunt precommit
updates numerous CSS files vendor prefixes and these changes require committing to the 5.0
branch.
The above changes should also be added to the /trunk
branch for 5.1
Attachments (3)
Change History (15)
#6
follow-up:
↓ 7
@
6 years ago
The CSS changes from [43784] appear to be already merged to trunk in [43309] and [44264].
The only thing left to commit from 45080-trunk.diff is removing the /* Fails with spaces?? Weird! */
comment. It used to be next to -webkit-transform: translate( 50%, 50% )
. [43784] moved it to height: 100%
in the next line, which doesn't make sense.
#7
in reply to:
↑ 6
;
follow-up:
↓ 10
@
6 years ago
Replying to SergeyBiryukov:
The only thing left to commit from 45080-trunk.diff is removing the
/* Fails with spaces?? Weird! */
comment. It used to be next to-webkit-transform: translate( 50%, 50% )
. [43784] moved it toheight: 100%
in the next line, which doesn't make sense.
Right, I believe the cause of this is that Autoprefixer cannot automatically remove vendor prefix lines if they have a comment at the end of the line.
As such the comment was moved, it should have been removed as it only applied to the vendor prefix line I believe.
#9
@
6 years ago
- Keywords commit removed
I think this is all set now. @netweb can you verify and close this out?
#10
in reply to:
↑ 7
@
6 years ago
- Keywords commit added
Replying to netweb:
Replying to SergeyBiryukov:
The only thing left to commit from 45080-trunk.diff is removing the
/* Fails with spaces?? Weird! */
comment. It used to be next to-webkit-transform: translate( 50%, 50% )
. [43784] moved it toheight: 100%
in the next line, which doesn't make sense.
Right, I believe the cause of this is that Autoprefixer cannot automatically remove vendor prefix lines if they have a comment at the end of the line.
As such the comment was moved, it should have been removed as it only applied to the vendor prefix line I believe.
Patch 45080.2.diff removes the /* Fails with spaces?? Weird! */
comment
Replying to desrosj:
I think this is all set now. @netweb can you verify and close this out?
Per the above, patch 45080.2.diff is required for /trunk
Attachment 45080-50.diff is for the
5.0
branchAttachment 45080-trunk.diff is for the
/trunk
branch