WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Last modified 8 years ago

#45083 new enhancement

use `image_default_size` option in WP_Widget_Media_Image instead of hard-coded value

Reported by: Toro_Unit Owned by:
Priority: normal Milestone: Future Release
Component: Widgets Version: 4.8
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

default image size in WP_Widget_Media_Image is 'medium'.

Should be used get_option( 'image_default_size', 'medium' )

Attachments (2)

45083.patch​ (716 bytes ) - added by Toro_Unit 8 years ago.
45083.diff​ (1.0 KB ) - added by welcher 8 years ago.

Download all attachments as: .zip

Change History (3)

@Toro_Unit
8 years ago

#1 @welcher
8 years ago

  • Milestone Awaiting Review → Future Release
  • Summary use `image_default_size` option in WP_Widget_Media_Image → use `image_default_size` option in WP_Widget_Media_Image instead of hard-coded value
  • Type defect (bug) → enhancement

@Toro_Unit thanks for the ticket and the patch!

This looks good to me.

I am wondering if we may want to consider adding a filter the return of the get_option call. This will allow users to change the default value of this widget without affecting the default size of other media throughout the site.

Patch updated.

@welcher
8 years ago

Note: See TracTickets for help on using tickets.