WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45110 closed task (blessed) (fixed)

Integrate client-side asset loading for the new editor

Reported by: desrosj Owned by: desrosj
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: General Keywords: fixed-5.0
Focuses: Cc:

Description

The code registering the client-side assets for the new editor currently exists in Gutenberg. This code should be in WordPress Core.

Change History (10)

#1 @youknowriad
3 years ago

Actually, this has already been moved to Core (scripts and styles registration), what's remaining is the function bootstraping the editor which I guess is the last thing we'll merge.

#2 @desrosj
3 years ago

  • Summary changed from Integrate client-side assets for the new editor to Integrate client-side asset loading for the new editor

Thanks, @youknowriad. I think you are referencing #45065 (related). I was not sure if all the code had made it over from client-assets.php, so wanted to open this to be sure. I updated the ticket title to reflect that this should ensure all of the PHP related code is merged. If everything is completed, then feel free to resolve this one as a duplicate.

#3 @youknowriad
3 years ago

yes, that's the ticket I was referring too. Thanks for the link.

I think all the registrations did move but there's still value in keeping this ticket open maybe as it mirrors the "client-assets.php" file which includes other functions in addition to the registration. I know that it's the file where the bootstrapping happens but not sure if there's anything else.

No harm in keeping this open then to ensure everything is moved at the end.

#4 @pento
3 years ago

In 43762:

Block Editor: Add helper functions for displaying the editor.

use_block_editor_for_post() and use_block_editor_for_post_type() determine if the block editor should be loaded.

get_block_categories() and get_block_editor_server_block_settings() provide data be included while the block editor is loading.

See #45110.

#5 @pento
3 years ago

In 43763:

REST API: Introduce the rest_preload_api_request() function.

This function helps perform multiple REST API requests, for the purpose of preloading data into a page.

See #45110.

#6 @pento
3 years ago

In 43764:

i18n: Remove some translation domains accidentally included in [43762].

See #45110.

#7 @pento
3 years ago

  • Keywords fixed-5.0 added; needs-patch needs-unit-tests removed

The last parts of client-assets.php will be included as part of #45037.

#8 @desrosj
3 years ago

In 44122:

Block Editor: Add helper functions for displaying the editor.

use_block_editor_for_post() and use_block_editor_for_post_type() determine if the block editor should be loaded.

get_block_categories() and get_block_editor_server_block_settings() provide data be included while the block editor is loading.

Props pento.

Merges [43762] to trunk.

See #45110.

#9 @desrosj
3 years ago

In 44123:

REST API: Introduce the rest_preload_api_request() function.

This function helps perform multiple REST API requests, for the purpose of preloading data into a page.

Props pento.

Merges [43763] to trunk.

See #45110.

#10 @desrosj
3 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 44124:

i18n: Remove some translation domains accidentally included in [43762], [44122].

Moves [43764] to trunk.

Fixes #45110.

Note: See TracTickets for help on using tickets.