WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45117, comment 1


Ignore:
Timestamp:
10/18/2018 11:58:29 AM (8 years ago)
Author:
azaozz

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #45117, comment 1

    initial v1  
    1 Ideally the TinyMCE init settings should be abstracted in `class-wp-editor.php` and then used in script-loader. If that's likely to cause problems and we must duplicate that code (needs more looking into), we should add the "by-hand" translation from PHP to JS for the settings array, see https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes/class-wp-editor.php#L723. That will also support passing of a JS function to some settings, which is somewhat common.
     1Ideally the TinyMCE init settings should be abstracted in `class-wp-editor.php` and then used in script-loader. If that's likely to cause problems and we must duplicate that code (needs more looking into), we should add the "by-hand" translation from PHP to JS for the settings array, see https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes/class-wp-editor.php#L723.
     2
     3That will also support using a JS function for some settings, which is somewhat common.