wp-personal-data-export cron error if folder not exists - create folder

[DuckDagobert]

Fix the wp-personal-data-exports function that is hooked to cron that it will create the folder if it doesn't exist.

PHP Error: opendir(/mypath/wp-content/uploads/wp-personal-data-exports/): failed to open dir: No such file or directory
File: /mypath/wp-admin/includes/file.php on line 143
Error URL: ​https://myurl.com/wp-cron.php
Trace:
#1 /mypath/wp-admin/includes/file.php(143): opendir()
#2 /mypath/wp-includes/functions.php(6056): list_files(, 100, Array)
#3 /mypath/wp-includes/class-wp-hook.php(286): wp_privacy_delete_old_export_files()
#4 /mypath/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(, Array)
#5 /mypath/wp-includes/plugin.php(515): WP_Hook->do_action(Array)
#6 /mypath/wp-cron.php(126): do_action_ref_array(wp_privacy_dele..., Array)

PHP Error: closedir() expects parameter 1 to be resource, boolean given
File: /mypath/wp-admin/includes/file.php on line 168
Error URL: ​https://myurl.com/wp-cron.php
Trace:
#1 /mypath/wp-admin/includes/file.php(168): closedir(false)
#2 /mypath/wp-includes/functions.php(6056): list_files(, 100, Array)
#3 /mypath/wp-includes/class-wp-hook.php(286): wp_privacy_delete_old_export_files()
#4 /mypath/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(, Array)
#5 /mypath/wp-includes/plugin.php(515): WP_Hook->do_action(Array)
#6 /mypath/wp-cron.php(126): do_action_ref_array(wp_privacy_dele..., Array)

[desrosj]

Thanks for the ticket, @DuckDagobert!

Can you share any more information about your environment? I am currently unable to replicate this issue.

Both opendir() and closedir() are prefixed by @ on the lines in question, which should suppress the E_WARNING level error triggered if the directory does not exist.

It's possible you have a custom error handler defined using set_error_handler() that is ignoring the @.

[DuckDagobert]

Sorry for the late reply, somehow it didn't save my comment the first time round, so I resubmit it now (bc I just checked if anybody replied):

Yes I am using a custom error handler.

I wonder why it doesn't just create the folder if it doesn't exist, instead of suppressing the error with

@desrosj

[arena]

I confirm that this is a bug.

Apparently, the directory 'wp-personal-data-exports' is only created when the first personal data file is generated.

On the other side, the wp-cron job scans every hour the directory 'wp-personal-data-exports' and do not test if the folder exists. ( hook name : wp_privacy_delete_old_export_files )

My config :

• Version de WordPress : 5.1-alpha-44356
• Version de PHP/MySQL : 7.2.3 / 5.7.17

wp-cron called by :

/wordpress/wp-cron.php?doing_wp_cron=1545348420.1551721096038818359375

WARNINGS :

PHP [E_WARNING] 2 : opendir( X:\..\wordpress/wp-content/uploads/wp-personal-data-exports/,wordpress/wp-content/uploads/wp-personal-data-exports/): The system cannot find the file specified. (code: 2) in wordpress\wp-admin\includes\file.php at line 143

PHP [E_WARNING] 2 : opendir( X:\..\wordpress/wp-content/uploads/wp-personal-data-exports/): failed to open dir: No such file or directory in wordpress\wp-admin\includes\file.php at line 143

PHP [E_WARNING] 2 : closedir() expects parameter 1 to be resource, boolean given in wordpress\wp-admin\includes\file.php at line 168

[arena]

patch #45136 ... testing exports_dir

[arena]

Patch working like a charm !
No more warnings !

[garrett-eclipse]

Thanks for the patch @arena as well as the report @DuckDagobert

@arena would you mind refreshing the patch with two minor things;

1. Remove the initial empty line introduced after the function declaration and the first line of code.
2. Generate the patch from the root directory, currently running grunt patch:45136 results in error as the patch was diff'd from the same directory as the file and not the root of the repository.

   Running "patch:45136" (patch) task
   (Stripping trailing CRs from patch.)
   can't find file to patch at input line 5
   Perhaps you used the wrong -p or --strip option?
   The text leading up to this was:
   --------------------------
   |Index: functions.php
   |===================================================================
   |--- functions.php	(revision 44186)
   |+++ functions.php	(working copy)
   --------------------------
   

Quoting - 'ensure that you are in the root directory created by your SVN checkout'
Reference - ​https://make.wordpress.org/core/handbook/tutorials/working-with-patches/#creating-a-patch

Thanks

[arena]

patch as required

[garrett-eclipse]

Minor update to adhere to Coding Standards

[garrett-eclipse]

Thanks @arena I appreciate the refresh. I made another minor refresh in 45136.2.diff to adhere to the coding standards for ​Space Usage and avoiding ​Clever Code.

Moving this into 5.2 for some additional testing and flagging for unit tests as it may warrant them but am unsure if required. Will review with the team on Monday.
Cheers

[desrosj]

In 44910:

Privacy: Do not attempt to cleanup personal data export files when the directory does not exist.

Checking for the presence of the directory and returning early prevents PHP warnings when attempting to list files in a non-existent directory.

Props arena, garrett-eclipse.
Fixes #45136.

[SergeyBiryukov]

#46741 was marked as a duplicate.

[SergeyBiryukov]

#46740 was marked as a duplicate.