WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45152 closed task (blessed) (fixed)

Make twentynineteen the default theme

Reported by: jorbin Owned by: jorbin
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: fixed-5.0
Focuses: Cc:

Description

After [43808], we can now make twentynineteen the default

Attachments (5)

45152.diff (1.7 KB) - added by jorbin 3 years ago.
45152.2.diff (4.5 KB) - added by SergeyBiryukov 3 years ago.
45152.3.diff (3.4 KB) - added by pento 3 years ago.
45152.4.diff (4.8 KB) - added by pento 3 years ago.
45152.5.diff (5.7 KB) - added by pento 3 years ago.

Download all attachments as: .zip

Change History (23)

@jorbin
3 years ago

This ticket was mentioned in Slack in #core-committers by jorbin. View the logs.


3 years ago

#2 @desrosj
3 years ago

  • Keywords has-patch commit added

Tested 45152.diff and Twenty Nineteen is correctly applied as the default theme for a new install.

#3 @jorbin
3 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 43809:

Bundled Theme: Make twentynineteen the default theme.

After [43808], we can now make twentynineteen the default theme. Twentyseventeen has been a great default, but 5.0 and twentynineteen is guten.

Fixes #45152.

#4 @jorbin
3 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

reopening for merge to trunk when trunk is open again

#5 @SergeyBiryukov
3 years ago

The help text on wp-admin/nav-menus.php needs an update as well, also the sidebars_widgets option.

See [38919] and [38920] for Twenty Seventeen.

This ticket was mentioned in Slack in #core-committers by sergey. View the logs.


3 years ago

#7 @SergeyBiryukov
3 years ago

  • Keywords dev-feedback added; fixed-5.0 removed

In 45152.2.diff:

  • Update nav menus help text.
  • Update sidebars_widgets option to match Twenty Nineteen's zero sidebars.
  • Skip some unit tests that depend on current theme's sidebars.

When searching for seventeen, I've also found the DocBlock for WP_Theme_Install_List_Table::single_row(). Since http://2019.wordpress.net/ does not exist, I guess we can leave that one as is for now?

#8 @pento
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

45152.2.diff looks good, I agree about leaving the DocBlock for WP_Theme_Install_List_Table::single_row() for now.

#9 @pento
3 years ago

  • Keywords needs-refresh added; commit dev-reviewed removed

Twenty Nineteen has added a widget area.

#10 @pento
3 years ago

  • Type changed from enhancement to task (blessed)

Converting to a task, this can happen during RC.

#11 @pento
3 years ago

@karmatosed, @melchoyce: Is there likely to be a 2019.wordpress.net site created?

#12 @karmatosed
3 years ago

@pento let me loop in @kjellr on this regarding the demo site.

#13 @kjellr
3 years ago

Is there likely to be a 2019.wordpress.net site created?

@pento Yes! It's in progress at the moment, but the URL will be 2019.wordpress.net. 👍

@pento
3 years ago

#14 @pento
3 years ago

  • Keywords needs-refresh removed

In 45152.3.diff:

  • The nav menu help text is updated to refer to Twenty Nineteen. (This isn't a translatable string change.)
  • Update the docblock for WP_Theme_Install_List_Table::single_row() to refer to Twenty Nineteen.

@pento
3 years ago

@pento
3 years ago

#15 @pento
3 years ago

In 45152.5.diff:

Update sidebars_widgets to match Twenty Nineteen's single widget area, and update the customizer tests to match.

This ticket was mentioned in Slack in #core by matias. View the logs.


3 years ago

#17 @mcsf
3 years ago

  • Keywords fixed-5.0 added; has-patch removed

In 43954:

Update sidebars_widgets to match Twenty Nineteen's single widget area

  • Also update the customizer tests to match it.

Props SergeyBiryukov, pento.

#18 @pento
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44151:

Bundled Themes: Make twentynineteen the default theme.

After [44149], we can now make twentynineteen the default theme. Twentyseventeen has been a great default, but 5.0 and twentynineteen is guten.

Merges [43809,43954] from the 5.0 branch to trunk.

Fixes #45152.
Props jorbin, SergeyBiryukov, pento, mcsf.

Note: See TracTickets for help on using tickets.