Opened 6 years ago
Closed 6 years ago
#45152 closed task (blessed) (fixed)
Make twentynineteen the default theme
Reported by: | jorbin | Owned by: | jorbin |
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | fixed-5.0 |
Focuses: | Cc: |
Description
After [43808], we can now make twentynineteen the default
Attachments (5)
Change History (23)
This ticket was mentioned in Slack in #core-committers by jorbin. View the logs.
6 years ago
#3
@
6 years ago
- Owner set to jorbin
- Resolution set to fixed
- Status changed from new to closed
In 43809:
#4
@
6 years ago
- Keywords fixed-5.0 added
- Resolution fixed deleted
- Status changed from closed to reopened
reopening for merge to trunk when trunk is open again
This ticket was mentioned in Slack in #core-committers by sergey. View the logs.
6 years ago
#7
@
6 years ago
- Keywords dev-feedback added; fixed-5.0 removed
In 45152.2.diff:
- Update nav menus help text.
- Update
sidebars_widgets
option to match Twenty Nineteen's zero sidebars. - Skip some unit tests that depend on current theme's sidebars.
When searching for seventeen
, I've also found the DocBlock for WP_Theme_Install_List_Table::single_row(). Since http://2019.wordpress.net/ does not exist, I guess we can leave that one as is for now?
#8
@
6 years ago
- Keywords dev-reviewed added; dev-feedback removed
45152.2.diff looks good, I agree about leaving the DocBlock for WP_Theme_Install_List_Table::single_row()
for now.
#9
@
6 years ago
- Keywords needs-refresh added; commit dev-reviewed removed
Twenty Nineteen has added a widget area.
#10
@
6 years ago
- Type changed from enhancement to task (blessed)
Converting to a task, this can happen during RC.
#13
@
6 years ago
Is there likely to be a 2019.wordpress.net site created?
@pento Yes! It's in progress at the moment, but the URL will be 2019.wordpress.net. 👍
#14
@
6 years ago
- Keywords needs-refresh removed
In 45152.3.diff:
- The nav menu help text is updated to refer to Twenty Nineteen. (This isn't a translatable string change.)
- Update the docblock for
WP_Theme_Install_List_Table::single_row()
to refer to Twenty Nineteen.
#15
@
6 years ago
In 45152.5.diff:
Update sidebars_widgets
to match Twenty Nineteen's single widget area, and update the customizer tests to match.
Tested 45152.diff and Twenty Nineteen is correctly applied as the default theme for a new install.